search

iusrepo / wishlist

meta repo for IUS new package requests
34 stars 8 forks source link

php74-pecl-igbinary #276

Closed davidalger closed 4 years ago

davidalger commented 4 years ago

What new package do you want?

php74-pecl-igbinary

Testing

I agree to test the new package to ensure that it works as expected. Once I am satisfied with the results of my testing I will comment on this issue with the word "STABLE" to get it promoted to the stable repos.

davidalger commented 4 years ago

@carlwgeorge I've ported this package from Fedora upstream, verified it builds linking with php74 in ius-testing and transferred it into IUS for review/publishing: https://github.com/iusrepo/php74-pecl-igbinary

davidalger commented 4 years ago

Also a quick note here: I ported this based on the history for version 3.0.1 in the Fedora upstream as the recent updates in Fedora pushing it to 3.1.0 and 3.1.1 both result in test failures. The following is from building 3.1.0; version 3.1.1 resolves one of the failures, but not both of them, so in order to get a working version ported I opted to keep the port at version 3.0.1 rather than attempt to unravel why tests are failing in the latest upstream release.

=====================================================================
TIME END 2020-06-05 13:39:27

=====================================================================
TEST RESULT SUMMARY
---------------------------------------------------------------------
Exts skipped    :    0
Exts tested     :   17
---------------------------------------------------------------------

Number of tests :  111               104
Tests skipped   :    7 (  6.3%) --------
Tests warned    :    0 (  0.0%) (  0.0%)
Tests failed    :    2 (  1.8%) (  1.9%)
Tests passed    :  102 ( 91.9%) ( 98.1%)
---------------------------------------------------------------------
Time taken      :    3 seconds
=====================================================================

=====================================================================
FAILED TEST SUMMARY
---------------------------------------------------------------------
Test unserialization of classes derived from ArrayIterator [tests/__serialize_012.phpt]
__serialize() mechanism (015): Uninitialized properties from __sleep can be serialized and unserialized [tests/__serialize_015.phpt]
=====================================================================
error: Bad exit status from /var/tmp/rpm-tmp.H9h1vd (%check)

RPM build errors:
    Bad exit status from /var/tmp/rpm-tmp.H9h1vd (%check)
carlwgeorge commented 4 years ago

That was certainly a reasonable decision, I would have likely done the same. Thanks for your work on this and the other packages. php74-pecl-igbinary-3.0.1-3.el7.ius is now available in the testing repo.

davidalger commented 4 years ago

Have not extensively tested msgpack or igbinary extension APIs, but both appear to install and load as expected in combination with pecl-redis (and unless I'm mistaken, use of pecl-redis is by far going to be the most common reason this ext is installed). Redis is recognizing this as a serialization type:

[root@a4d70d2928b4 /]# php --ri redis

redis

Redis Support => enabled
Redis Version => 5.2.2
Redis Sentinel Version => 0.1
Available serializers => php, json, igbinary, msgpack
Available compression => lzf, zstd

If you're ok with it, I'm going to say let's give both #276 (igbinary) and #277 (msgpack) a green light.

carlwgeorge commented 4 years ago

Thanks for testing. This has been promoted to the main repository.