search

iustin / pyxattr

A python module for accessing filesystem Extended Attributes
https://pyxattr.k1024.org/
GNU Lesser General Public License v2.1
30 stars 15 forks source link

Test failures with pypy #2

Closed mgorny closed 11 years ago

mgorny commented 11 years ago

I have tested current git with pypy1.9 and pypy2.0, and in both cases I get test failures like:

======================================================================
ERROR: test binary values (deprecated functions)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/tmp/portage/dev-python/pyxattr-9999/work/pyxattr-9999/test/test_xattr.py", line 309, in testBinaryPayloadDeprecated
    xattr.setxattr(fname, self.USER_ATTR, BINVAL)
IOError: [Errno 7] Argument list too long

It seems that the Python extension uses functions in some way which is incompatible with PyPy…

mgorny commented 11 years ago

Gentoo bugreport: https://bugs.gentoo.org/show_bug.cgi?id=448084 Build log: https://448084.bugs.gentoo.org/attachment.cgi?id=334094 (it seems that github doesn't support attaching files)

iustin commented 11 years ago

Thanks for the report, I'll take a look at it.

iustin commented 11 years ago

The problem seems to be that the size of various strings as parsed from Python is wrong, leading to extended attribute sizes that are clearly wrong being passed to setxattr() and friends.

iustin commented 11 years ago

OK, this is fixed now, except I used the wrong issue id in commit a37fdf32.

iustin commented 11 years ago

OK, so I was ready to release 0.5.2 with the fix, just to learn that github has deprecated downloads, so I have to upload the archive somewhere else.

In the meantime, if you can test the current master branch, would be appreciated.

mgorny commented 11 years ago

They did? Oh my… I guess I ran to bitbucket in time.

Since this is a Python package, I guess you can use pypi to host the archives.

mgorny commented 11 years ago

I've just tested it and tests pass fine for me.

iustin commented 11 years ago

Glad to hear. OK, new release up, both on pypi (http://pypi.python.org/pypi/pyxattr/) and own my own site (http://pyxattr.k1024.org/downloads).