iusztinpaul / hands-on-llms

๐Ÿฆ– ๐—Ÿ๐—ฒ๐—ฎ๐—ฟ๐—ป about ๐—Ÿ๐—Ÿ๐— ๐˜€, ๐—Ÿ๐—Ÿ๐— ๐—ข๐—ฝ๐˜€, and ๐˜ƒ๐—ฒ๐—ฐ๐˜๐—ผ๐—ฟ ๐——๐—•๐˜€ for free by designing, training, and deploying a real-time financial advisor LLM system ~ ๐˜ด๐˜ฐ๐˜ถ๐˜ณ๐˜ค๐˜ฆ ๐˜ค๐˜ฐ๐˜ฅ๐˜ฆ + ๐˜ท๐˜ช๐˜ฅ๐˜ฆ๐˜ฐ & ๐˜ณ๐˜ฆ๐˜ข๐˜ฅ๐˜ช๐˜ฏ๐˜จ ๐˜ฎ๐˜ข๐˜ต๐˜ฆ๐˜ณ๐˜ช๐˜ข๐˜ญ๐˜ด
MIT License
2.68k stars 427 forks source link

Missing train_finqa.py file required for dev_train_beam target in Makefile #33

Closed bardbardd0lm55 closed 8 months ago

bardbardd0lm55 commented 8 months ago

Description

I am trying to execute the dev_train_beam target from the Makefile, but it seems like the train_finqa.py file, which is supposed to be located in the ./tools directory, is missing from the repository.

Steps to Reproduce

  1. Navigate to the training_pipeline directory.
  2. Run the command make dev_train_beam.

Expected Behavior

The make dev_train_beam command should execute successfully by running the Beam training pipeline using the train_finqa.py script.

Actual Behavior

An error is thrown indicating that the train_finqa.py file is not found:

Additional Information

Questions

Thank you for your assistance!

iusztinpaul commented 8 months ago

Hello,

Just change it with train_run.py. We changed the file name and forgot to update all Makefile commands.

Thanks for letting us know.

iusztinpaul commented 8 months ago

I fixed this in this PR: https://github.com/iusztinpaul/hands-on-llms/pull/34

It is not merged as it is still a WIP, but you can take a look and inspire.

bardbardd0lm55 commented 8 months ago

I feel dumb, it was that simple, i should've look more carefully, thank you so much! next time i will come up with something better. I love the work you guys have done. thanks again.

iusztinpaul commented 7 months ago

@bardbardd0lm55 No worries, it happens.

I am happy you take our course ๐Ÿ”ฅ

MotiBaadror commented 3 days ago

I am facing one issue, make dev_train_beam , copying whole environment and taking too much time