search

iusztinpaul / hands-on-llms

🦖 𝗟𝗲𝗮𝗿𝗻 about 𝗟𝗟𝗠𝘀, 𝗟𝗟𝗠𝗢𝗽𝘀, and 𝘃𝗲𝗰𝘁𝗼𝗿 𝗗𝗕𝘀 for free by designing, training, and deploying a real-time financial advisor LLM system ~ 𝘴𝘰𝘶𝘳𝘤𝘦 𝘤𝘰𝘥𝘦 + 𝘷𝘪𝘥𝘦𝘰 & 𝘳𝘦𝘢𝘥𝘪𝘯𝘨 𝘮𝘢𝘵𝘦𝘳𝘪𝘢𝘭𝘴
MIT License
3.12k stars 483 forks source link

Fix qdrant upload #68

Closed laziale2 closed 10 months ago

laziale2 commented 10 months ago

Fix that allow to push correctly all downloaded data from Alpaca (make embed). Without this fix the upload script always overrides chunks in qdrant cause the id of Points is always 1-2-3 ...

iusztinpaul commented 10 months ago

Hello,

Thanks for contributing to our code base.

Your observation is correct, but the code already has your modifications.

Maybe you have some old version.

laziale2 commented 10 months ago

Hi Paul,

are you sure that the code already contains my modification in "q_and_a_dataset_generator" module? I pulled latest version from main. Cause i see the code with modification only in module "streaming_pipeline". Let me know :)

iusztinpaul commented 10 months ago

@laziale2 You are right. I was thinking only about the streaming_pipeline module and missed that you updated the q_and_a_dataset_generator module.

Then everything is alright. I accepted your PR. Thanks for contributing.