Change to Qt 5

[abroxos]

Replace Qt 4 with Qt 5: Todo:

BASIC:

• [x] Implementation
• [x] Core (usage: cmake option "-DUSEQT5=ON")
• [x] Integrate qglviewer sources in GUI submodule and static link the lib with dynamind-gui executable (Dynamind compiles with qglviewer <= 2.5.0)

MODULES:

• [x] BASICMODULES modules
• [x] DYNAVIBE modules
• [x] DYNALP modules
• [x] SEWER modules
• [x] GDALMODULE modules
• [x] PERFORMANCE_ASSESSMENT modules
• [x] STANDALONE_EXE

TESTS:

• [x] Unit Tests (Core)
• [ ] Upgrade Jenkins
• [x] Testing on Linux
• [x] Testing on OSX
• [ ] Testing Windows

[christianurich]

In OS X the GUI stuff is still not fixed in Qt 4.8 and I was wondering how the transition to Qt5 is going?

[abroxos]

Hi Christian, currently dynamind-toolbox has a cmake option "-DUSEQT5=ON/OFF". We have tested it in linux. It would be nice if you test this in OSX. The core and gui should work. In the top CMakeLists.txt you will find lines like "if(NOT USEQT5 AND WITHPLUGIN...". representing modules which need code adaptation. Let me know if core and gui works on OSX. Anyway we will give this issue a higher priority now.

[ghost]

I've tested QT5 with BASICMODULES and DYNALP Modules and see no problem so far.

From Basicmodules I use:

• ImportwithGDAL
• CalculateCentroid
• ConditionalLoopGroup
• FaceToEdge
• Export

from DynAlp I use everything :)

EDIT: I also enabled -DQGL_FROM_SOURCE=ON

full cmake command:

cmake ../ -DUSEQT5=ON -DQGL_FROM_SOURCE=ON -DWITH_PLUGIN_DYNALP=ON -DWITH_PLUGIN_BASICMODULES=ON

For that I changed the CMakeList.txt so I can use both QT5 and the plugins

[attozeta]

Actually the changes are pretty minor, however I can not push to DynaMind-GDALModules and CityDrain3 as I do not have write access. However I have a working patch. Furthermore QGL_FROM_SOURCE is now the default option.

[christianurich]

If you can send me a pull request I'll merge it

[christianurich]

Hi, the OS X build has issues with the qglviewer that are annoying to resolve. Since I don't need the viewer anyway I just added another option that disables the viewer. -WITH_VIEWER

[christianurich]

Besides the viewer everything works now for me. Thanks!!

For Testing:

export CMAKE_PREFIX_PATH=/usr/local/opt/qt5/
cmake ../../ -DUSEQT5=ON -DQGL_FROM_SOURCE=OFF -DWITH_VIEWER=OFF -DWITH_PLUGIN_DYNALP=OFF -DWITH_PLUGIN_BASICMODULES=ON -DWITH_UNIT_TESTS=True -DWITH_PLUGIN_GDALMODULE=True -DWITH_PLUGIN_PERFORMANCE_ASSESSMENT=True -DWITH_DOC=True -DWITH_PLUGIN_GDALDRAINAGE=ON -DWITH_UNIT_TESTS=ON -DWITH_PLUGIN_SEWER=OFF

[abroxos]

Thank you for testing. What was the problem. Do you have any build output ?

[christianurich]

Mainly the cmake configuration itself, the qmake in the cmake didn't work (qmake was not found properly). This can be fixed with get_target_property (QT_QMAKE_EXECUTABLE Qt5::qmake IMPORTED_LOCATION). The real problem was that the qglviewer couldn't link against the standard library which I couldn't fix.

[abroxos]

Finally fixed qglviewer build on OSX:

Please edit in /usr/local/Cellar/qt5/5.4.2/mkspecs/macx-clang/qmake.conf from

QMAKE_MACOSX_DEPLOYMENT_TARGET = 10.6

to

QMAKE_MACOSX_DEPLOYMENT_TARGET = 10.9

and make a clean build

This should fix the build issues.