search

iv-org / invidious-helm-chart

The helm chart for setting up Invidious with kubernetes.
GNU Affero General Public License v3.0
1 stars 1 forks source link

Provide update method of sql files (or move those from chart itself) #2

Open JuniorJPDJ opened 2 months ago

JuniorJPDJ commented 2 months ago 
I'm not sure if holding sql files inside the chart is a good idea as it will become out of date quickly.
If you can propose (or even better - implement) some solution to make it not become out of date

Originally posted by @JuniorJPDJ in https://github.com/iv-org/invidious-helm-chart/issues/1#issuecomment-2133892663

CC: @perennialtech

perennialtech commented 2 months ago

I'm not sure if holding sql files inside the chart is a good idea as it will become out of date quickly.

This issue never really crossed my mind.

I've been had the SQL files as a ConfigMap in a local Helm chart for several months without encountering any issues. It's also worth noting that the last change to the Invidious SQL schema was made over two years ago (see https://github.com/iv-org/invidious/commit/cdc007c83cafba9884470af0167edd8dd70a0b1d).

On the other hand, I'm not too sure how to handle migrations for the database if they ever become necessary in the future. Perhaps a solution could be implementing a custom migration script that is triggered by a Helm hook?

JuniorJPDJ commented 2 months ago

I'm not sure invidious is implementing any migrations, those sql files are used only for db init.

SamantazFox commented 1 month ago

Invidious does indeed have a built-in migration system, which to this date has not been used because a proper init and upgrade process for docker needs to be documented.

We have a bunch of PRs making DB changes that are waiting to be merged.