iv-org / invidious.io

The Invidious.io website
https://invidious.io
64 stars 25 forks source link

Make the website entirely static and almost JavaScript free #57

Closed TheFrenchGhosty closed 2 years ago

TheFrenchGhosty commented 2 years ago

This PR:

The website looks absolutely the same (other than the JS features, and the fonts that were removed) while simplifying thing a TON.

Screenshots: (Note: the GitHub icon at the top right doesn't work in my browser for whatever reason, but it's still here)

Homepage: homepage

Donate page: donate

unixfox commented 2 years ago

IMO the website looks better in white than in dark.

TheFrenchGhosty commented 2 years ago

@unixfox This is an 1 word change (see: https://github.com/iv-org/invidious.io/pull/57/commits/30d01552c7663ff1b8faaa7a0da7ce4b7c881519 ), this is true that the dark theme isn't great, so why not, sure.

unixfox commented 2 years ago

Can we keep the JS functions just for switching between dark and white? I think the theme should be white by default.

TheFrenchGhosty commented 2 years ago

@unixfox I don't know from which JS it's from (edit: it's main.js), I'll take a look, but sure.

TheFrenchGhosty commented 2 years ago

@unixfox Done

(I added the JS as-is, it ideally needs to have to have the unused function removed from it - but I'm not a JS developer, so I don't want to touch it)

TheFrenchGhosty commented 2 years ago

@SamantazFox So you agree in us dropping the building framework, correct?

SamantazFox commented 2 years ago

I mean, yeah? Not like we'll use it often, and we can still go back in git history if we need it again...