iv-org / invidious

Invidious is an alternative front-end to YouTube
https://invidious.io
GNU Affero General Public License v3.0
16.43k stars 1.85k forks source link

[Feature request] Improve VR projection type detection #2394

Open syeopite opened 3 years ago

syeopite commented 3 years ago

Is your enhancement request related to a problem? Please describe.

In order to render a VR video correctly, we need a projection type. Invidious currently attempts to detect this via the projectionType attribute in the adaptiveFormats.

https://github.com/iv-org/invidious/blob/50c8afb525429dcdb5a9b9bb4cf798ee9f62da2a/src/invidious/videos.cr#L764-L767

However, this method isn't ideal:

Describe the solution you'd like

Find some full proof method to detect the exact projection type.

Describe alternatives you've considered

Since MESH can either be EAC or EAC_LR we can add a button to let the end-user quickly swap projection types so they can attempt to fix the video themselves.

Additional context

iBicha commented 7 months ago

Reviving this - is EQUIRECTANGULAR still being used? I haven't seen it in a while