[Enhancement] Allow video duration units to go up to days

iv-org / invidious

Invidious is an alternative front-end to YouTube

https://invidious.io

GNU Affero General Public License v3.0

15.56k stars 1.71k forks source link

[Enhancement] Allow video duration units to go up to days #4102

Open syeopite opened 9 months ago

syeopite commented 9 months ago

Is your enhancement request related to a problem? Please describe.

Video durations are limited to a maximum unit of hours whereas YouTube supports up to days (but only on the video playback page).

Describe the solution you'd like

For Invidious to support a day unit within the duration. Various other places in Invidious such as the VTT logic would also need to be updated.

Describe alternatives you've considered

Additional context

Youtube: youtube

Invidious:

SamantazFox commented 9 months ago

Does Youtube allows VOD that are 200h long? I though they didn't provide VOD for long livestreams!

Also, how big are the odds of finding a 24h+ video on Youtube? Is this change really worth it?

syeopite commented 9 months ago

That particular video isn't actually a VOD. It's a 200 hour timer video https://www.youtube.com/watch?v=mivcDoTjpQE

Does Youtube allows VOD that are 200h long? I though they didn't provide VOD for long livestreams!

They technically do but the VOD would just be in eternal processing (though it could just be because of how long this particular VOD is at over 20k hours...) https://www.youtube.com/watch?v=5qap5aO4i9A

Also, how big are the odds of finding a 24h+ video on Youtube? Is this change really worth it?

It's definitely low priority but a nice quality of life change.

SamantazFox commented 9 months ago

Loading that page almost crashed my browser :x Invidious can't play the video in the first place!

syeopite commented 9 months ago

Yep that's a separate issue. See #3220.

The video does eventually load without DASH though.

SamantazFox commented 9 months ago