[Bug] formatStreams.size parameter wrong in API response, always returns 16:9

iv-org / invidious

Invidious is an alternative front-end to YouTube

https://invidious.io

GNU Affero General Public License v3.0

16.27k stars 1.8k forks source link

[Bug] formatStreams.size parameter wrong in API response, always returns 16:9 #4131

Closed iGerman00 closed 2 months ago

iGerman00 commented 1 year ago

Describe the bug The API response for a Shorts video isn't correct. The resolution (formatStreams.size) parameter is returning 1280x720 or otherwise 16:9, while the video is clearly 9:16.

The correct resolution is shown by tools like youtube-dl (screenshot attached).

Steps to Reproduce

Logs N/A

Screenshots WindowsTerminal (2023-09-29 20։12։55)

Additional context Multiple instances tested, all seemingly have this error

absidue commented 1 year ago

It's hardcoded in the code based on the itag, that part was probably written before shorts existed. Will probably be fixed by #3620.