search

iv-org / invidious

Invidious is an alternative front-end to YouTube
https://invidious.io
GNU Affero General Public License v3.0
16.06k stars 1.77k forks source link

[Enhancement] audio codec representation #4235

Open foxjaw opened 10 months ago

foxjaw commented 10 months ago

Is your enhancement request related to a problem? Please describe.

YES. This is related to a problem. See the below screenshot: Screenshot_20231030-183141

YouTube uses two audio codecs aac & opus. One has m4a container, & another's webm. If you listen carefully, opus stream with least quality (typically at 35 to 55 kbps) has amazing audio quality compared to the highest aac ones.

The problem is

In above screenshot, look at the audio quality list. There's no indication of codec type. There's only bitrate.

Describe the solution you'd like

I suggest remove that 5/6 digit number & implement something like m4a128k, webm55k, m4a64k, webm150k, etc. It's very useful.

Describe alternatives you've considered

Instead, you can also segregate streams into two categories inside the list. One with m4a & another with webm.

Additional context

Related to this, can you also look into #4181 and implement default audio quality setting, like how default video quality exists ?

unixfox commented 10 months ago

Related: https://github.com/iv-org/invidious/issues/3012

foxjaw commented 10 months ago

@unixfox It's not. #3012 is related to setting a default codec. This enhancement is showing the codec type in the list.

gsuberland commented 9 months ago

Also seems like there's a bug here - 135502k would be 135Mbps, which is definitely not correct for an audio stream. It's probably supposed to be 135502 bits per second, i.e. 135.5Kbps.

foxjaw commented 9 months ago

Yup. But I've opened this issue, not because of the wrong units, but because of the lack of codec representation. I wanna choose opus over m4a. But I can't estimate which stream is which with the current audio stream selection representation.