search

iv-org / invidious

Invidious is an alternative front-end to YouTube
https://invidious.io
GNU Affero General Public License v3.0
16.39k stars 1.83k forks source link

Hidden subs on YouTube shows "0 subscribers" on Invidious #459

Open Perflyst opened 5 years ago

Perflyst commented 5 years ago

If you hide the subscribers count on youtube, than invidious shows 0 subscribers.

omarroth commented 5 years ago

Similarly, likes and dislikes are 0 for videos that have them disabled, and disabled comment sections currently show "0 comments".

I would consider this expected behavior. Considering that /api/v1/channels needs to return an Int, is there another value that would be a better default? Or should Invidious hide the subcount it's equal to 0?

Perflyst commented 5 years ago

I think returning 0 in the API is correct but on the other hand Invidious should interprate the 0 hide it.

You cannot validate that there are 0 followers or if the number is hidden?

On April 1, 2019 12:36:33 AM UTC, Omar Roth notifications@github.com wrote:

Similarly, likes and dislikes are 0 for videos that have them disabled, and disabled comment sections currently show "0 comments".

I would consider this expected behavior. Considering that /api/v1/channels needs to return an Int, is there another value that would be a better default? Or should Invidious hide the subcount it's equal to 0?

omarroth commented 5 years ago

Expect this to be fixed by adding an isSubCountHidden field to the API, similar to "isLive":true and "lengthSeconds":0.

omarroth commented 5 years ago

Could you provide an example to test with?

Perflyst commented 5 years ago

Sorry for late reply, there are two channels who hide subscriber count:

https://invidio.us/channel/UCSFvTgGzmSfC5MWM1dBH_0g https://invidio.us/channel/UCcn4UOBvB0W2HjCcLFLuu2w

github-actions[bot] commented 3 years ago

This issue has been automatically marked as stale and will be closed in 30 days because it has not had recent activity and is much likely outdated. If you think this issue is still relevant and applicable, you just have to post a comment and it will be unmarked.

B0pol commented 3 years ago

bump

github-actions[bot] commented 2 years ago

This issue has been automatically marked as stale and will be closed in 30 days because it has not had recent activity and is much likely outdated. If you think this issue is still relevant and applicable, you just have to post a comment and it will be unmarked.

B0pol commented 2 years ago

It should be re-opened it's still an issue

unixfox commented 2 years ago

It should be re-opened it's still an issue

Can you give a proof?

SamantazFox commented 2 years ago

@unixfox Those examples are still relevant: https://github.com/iv-org/invidious/issues/459#issuecomment-508985890