search

iv-org / invidious

Invidious is an alternative front-end to YouTube
https://invidious.io
GNU Affero General Public License v3.0
16.19k stars 1.79k forks source link

Confirmation before connecting to youtube.com/youtu.be #4826

Open unlxam opened 1 month ago

unlxam commented 1 month ago

Closes #4798

I also thought that since we are adding a confirmation before going to youtube.com/youtu.be in the "Watch on YouTube (Embed)" and "[YT]" in the comments. It would make sense adding also to external domains from links in the description and comments too. What you think about that?

SamantazFox commented 1 month ago

Also, I realized that there was https://github.com/iv-org/invidious/pull/4667 pending. I merged, so can you rebase your change on that please?

unlxam commented 1 month ago

Also, I realized that there was #4667 pending. I merged, so can you rebase your change on that please?

Rebased, since this PR goes directly with the feature of the confirmation page, I added the rel="noreferrer noopener" to it too, and replaced the external youtube.com links change by #4667 to pass through the confirmation. Edit: I forgot to mention that I added the function to replace the links to the channel about/description too.