iv-org / invidious

Invidious is an alternative front-end to YouTube
https://invidious.io
GNU Affero General Public License v3.0
16.42k stars 1.85k forks source link

[Bug] latest docker image tag is now arm64 instead of amd64 #4880

Closed Drikanis closed 2 months ago

Drikanis commented 2 months ago

Describe the bug

Latest image tag in quay.io has been replaced with the arm64 build instead of the amd64 one.

There is now no longer any valid latest tag for amd64.

Steps to Reproduce

https://quay.io/repository/invidious/invidious?tab=tags&tag=latest

skopeo inspect docker://quay.io/invidious/invidious:latest
FATA[0000] Error parsing manifest for image: choosing image instance: no image found in image index for architecture amd64, variant "", OS linux

Logs

Screenshots

image image

Additional context

syeopite commented 2 months ago

We are aware of the problem and are working on fixing it

SamantazFox commented 2 months ago

I found why it wasn't working: https://github.com/docker/metadata-action?tab=readme-ov-file#latest-tag

When using type=semver, docker/metadata-action auto-generates the latest tag. We need to add latest=false under flavor

SamantazFox commented 2 months ago

We also need to remove the enable condition, as github.ref is empty when a tag is pushed.

For instance, if I do the following

        with:
          images: quay.io/invidious/invidious
          flavor: |
            latest=false
            suffix=-arm64
          tags: |
            type=semver,pattern={{version}}
            type=raw,value=latest-{{github.ref}}
          labels: |
            quay.expires-after=12w

I'm getting (see this action):

Docker tags
  quay.io/invidious/invidious:69.69.69-arm64
  quay.io/invidious/invidious:latest--arm64