search

iv-org / invidious

Invidious is an alternative front-end to YouTube
https://invidious.io
GNU Affero General Public License v3.0
16.42k stars 1.85k forks source link

[Enhancement] Somehow move INVIDIOUS_CONFIG to external file? #4881

Closed TheSainEyereg closed 2 months ago

TheSainEyereg commented 2 months ago

Is your enhancement request related to a problem? Please describe. The method described at https://docs.invidious.io/improve-public-instance/#2-multiple-invidious-processes implies a complete duplication of the entire section, including INVIDIOUS_CONFIG. So now to edit something in the configuration you have to edit both sections and make sure they have the same settings.

This is not only inconvenient, but also opens up the possibility of human error, especially when now you need to additionally enter and change visitor_data and po_token.

Describe the solution you'd like Ability to mount a file from a local machine inside a container. Ideally, this would also solve the problem of changing settings using the web UI

Describe alternatives you've considered Manually edit docker-compose.yml :(

TheSainEyereg commented 2 months ago

Why are these bots targeting me lmao

unixfox commented 2 months ago

I don't understand if you just remove the env INVIDIOUS_CONFIG then you can mount the config.yaml. everything will work as you expect.

TheSainEyereg commented 2 months ago

I don't understand if you just remove the env INVIDIOUS_CONFIG then you can mount the config.yaml. everything will work as you expect.

Oh, so you can really make it that easy? Would it be better to put information about it in the documentation

unixfox commented 2 months ago

I don't understand if you just remove the env INVIDIOUS_CONFIG then you can mount the config.yaml. everything will work as you expect.

Oh, so you can really make it that easy? Would it be better to put information about it in the documentation

Feel free to improve the documentation :)!

https://github.com/iv-org/documentation/blob/master/docs/configuration.md