Channels: Fix "Youtube API returned error 400"

[SamantazFox]

Closes #4029 Closes #5021 Closes #5029

Requires #5027 to be merged first. Does NOT address #4477

This PR also adds sort option for shorts.

[SamantazFox]

Videos and livestreams work, but the rest is still broken. No error, though, that's progress!

[Despernal]

I can validate this does fix the issue with both subscriptions and livestreams showing now and applying the patch below in issue 4975

4975

which i know is a temp solution makes master branch work again for me.

I have a private instance on a residential ip.

I appreciate the hard work

[iBicha]

Videos and livestreams work, but the rest is still broken. No error, though, that's progress!

Looks to me like there's some parser work to do. E.g. on the response for channel shorts, I see the shorts are under onResponseReceivedActions[1].reloadContinuationItemsCommand.continuationItems[i].richItemRenderer.content.shortsLockupViewModel

[Fijxu]

For now, this works well: https://inv.nadeko.net/channel/UC6nSFpj9HTCZ5t-N3Rm3-HA https://git.nadeko.net/Fijxu/invidious/commits/branch/master

[SamantazFox]

Looks to me like there's some parser work to do.

@iBicha Yes, I realized that late yesterday, but I had to go to sleep x) I've added a commit for podcasts this morning, and I'm currently working on the shorts.

[SamantazFox]

Deployed on the test instance!

Working so far:

• [x] Videos (however the "newest" link is not selected by default)
  • [x] newest
  • [x] oldest
  • [x] popular
• [ ] Shorts (Cast from Hash(String, JSON::Any) to String failed (TypeCastError))
  • [ ] newest
  • [ ] oldest
  • [ ] popular
• [x] Livestreams
  • [x] newest
  • [x] oldest
  • [x] popular
• [ ] Podcasts (Expected Hash for #[]?(key : String), not Array(JSON::Any) (Exception))
• [x] Releases

[SamantazFox]

Deployed on the test instance!

Working so far:

• [x] Videos
  • [x] newest
  • [x] oldest
  • [x] popular
• [x] Shorts
  • [x] newest
  • [x] oldest
  • [x] popular
• [x] Livestreams
  • [x] newest
  • [x] oldest
  • [x] popular
• [x] Podcasts - Works but no thumbnails
• [x] Releases
• [ ] Playlists - Works by alternance, I'm suspecting an A/B test for a new format

[mtarnawa]

@SamantazFox - I also tested your changes and everything seems to be working fine again, thanks so much, keeping fingers crossed this gets merged soon.

On a side note - what's the issue with playlists? I haven't noticed any problems.

[SamantazFox]

Here is my problem!

[SamantazFox]

@syeopite It might be a good idea to add a verified field to that AuthorFallback structure, as these new lockupViewModel and shortLockupViewModel are very empty: I had to stub the author_verified field to false.

[UltraBlackLinux]

I just pulled this commit and it doesn't seem to be solving the issue unfortunately

[cephi-sui]

I just pulled this commit and it doesn't seem to be solving the issue unfortunately

I just pulled the master container and this does seem to work on my end.

[UltraBlackLinux]

oop forgot to update my comment here: I pulled the master changes and continued to use the pre-built container from quay... Don't ask me what went through my head there