ivabus / lonelyradio

Lightweight Music Streamer
MIT License
48 stars 5 forks source link

failed to resolve: use of undeclared crate or module `lonelyradio_types` #5

Closed JasonSanDiego closed 5 days ago

JasonSanDiego commented 2 weeks ago

When attempting to install monoclient-s on Ubuntu 22.04 with Rust 1.80.1, I get this error message.

~$ cargo install --git https://github.com/ivabus/lonelyradio --tag 0.7.0 monoclient-s
    Updating git repository `https://github.com/ivabus/lonelyradio`
  Installing monoclient-s v0.7.0 (https://github.com/ivabus/lonelyradio?tag=0.7.0#29338f32)
    Updating crates.io index
     Locking 497 packages to latest compatible versions
      Adding async-broadcast v0.5.1 (latest: v0.7.1)
      Adding async-fs v1.6.0 (latest: v2.1.2)
      Adding async-io v1.13.0 (latest: v2.3.4)
      Adding async-lock v2.8.0 (latest: v3.4.0)
      Adding async-process v1.8.1 (latest: v2.2.4)
      Adding atspi v0.19.0 (latest: v0.24.0)
      Adding atspi-common v0.3.0 (latest: v0.8.0)
      Adding atspi-connection v0.3.0 (latest: v0.8.0)
      Adding atspi-proxies v0.3.0 (latest: v0.8.0)
      Adding bindgen v0.69.4 (latest: v0.70.1)
      Adding bitflags v1.3.2 (latest: v2.6.0)
      Adding calloop v0.12.4 (latest: v0.14.0)
      Adding calloop v0.13.0 (latest: v0.14.0)
      Adding calloop-wayland-source v0.3.0 (latest: v0.4.0)
      Adding clipboard-win v3.1.1 (latest: v5.4.0)
      Adding cocoa v0.25.0 (latest: v0.26.0)
      Adding cocoa-foundation v0.1.2 (latest: v0.2.0)
      Adding convert_case v0.4.0 (latest: v0.6.0)
      Adding core-foundation v0.9.4 (latest: v0.10.0)
      Adding core-graphics v0.23.2 (latest: v0.24.0)
      Adding core-graphics-types v0.1.3 (latest: v0.2.0)
      Adding core-text v20.1.0 (latest: v21.0.0)
      Adding coreaudio-rs v0.11.3 (latest: v0.12.1)
      Adding derive_more v0.99.18 (latest: v1.0.0)
      Adding drm v0.9.0 (latest: v0.12.0)
      Adding drm-ffi v0.5.0 (latest: v0.8.0)
      Adding drm-sys v0.4.0 (latest: v0.7.0)
      Adding event-listener v2.5.3 (latest: v5.3.1)
      Adding event-listener v3.1.0 (latest: v5.3.1)
      Adding fastrand v1.9.0 (latest: v2.1.1)
      Adding fontdb v0.18.0 (latest: v0.21.0)
      Adding futures-lite v1.13.0 (latest: v2.3.0)
      Adding gbm v0.12.0 (latest: v0.15.0)
      Adding gbm-sys v0.2.2 (latest: v0.3.0)
      Adding generic-array v0.14.7 (latest: v1.1.0)
      Adding gethostname v0.4.3 (latest: v0.5.0)
      Adding glow v0.13.1 (latest: v0.14.0)
      Adding hermit-abi v0.3.9 (latest: v0.4.0)
      Adding idna v0.5.0 (latest: v1.0.2)
      Adding image v0.24.9 (latest: v0.25.2)
      Adding imagesize v0.12.0 (latest: v0.13.0)
      Adding input v0.8.3 (latest: v0.9.0)
      Adding io-lifetimes v1.0.11 (latest: v2.0.3)
      Adding itertools v0.12.1 (latest: v0.13.0)
      Adding jni-sys v0.3.0 (latest: v0.4.0)
      Adding lazy-bytes-cast v5.0.1 (latest: v7.0.0)
      Adding libredox v0.0.2 (latest: v0.1.3)
      Adding linux-raw-sys v0.3.8 (latest: v0.6.5)
      Adding linux-raw-sys v0.4.14 (latest: v0.6.5)
      Adding malloc_buf v0.0.6 (latest: v1.0.0)
      Adding memmap2 v0.8.0 (latest: v0.9.4)
      Adding memoffset v0.7.1 (latest: v0.9.1)
      Adding metal v0.27.0 (latest: v0.29.0)
      Adding miniz_oxide v0.7.4 (latest: v0.8.0)
      Adding ndk v0.8.0 (latest: v0.9.0)
      Adding ndk-sys v0.5.0+25.2.9519653 (latest: v0.6.0+11769913)
      Adding nix v0.26.4 (latest: v0.29.0)
      Adding nix v0.27.1 (latest: v0.29.0)
      Adding polling v2.8.0 (latest: v3.7.3)
      Adding proc-macro-crate v1.3.1 (latest: v3.2.0)
      Adding quick-xml v0.34.0 (latest: v0.36.1)
      Adding redox_syscall v0.4.1 (latest: v0.5.3)
      Adding resvg v0.42.0 (latest: v0.43.0)
      Adding rustc-hash v1.1.0 (latest: v2.0.0)
      Adding rustix v0.37.27 (latest: v0.38.35)
      Adding rustybuzz v0.14.1 (latest: v0.18.0)
      Adding socket2 v0.4.10 (latest: v0.5.7)
      Adding strict-num v0.1.1 (latest: v0.2.0)
      Adding syn v1.0.109 (latest: v2.0.76)
      Adding toml_edit v0.19.15 (latest: v0.22.20)
      Adding ttf-parser v0.21.1 (latest: v0.24.1)
      Adding udev v0.7.0 (latest: v0.9.0)
      Adding unicode-bidi-mirroring v0.2.0 (latest: v0.3.0)
      Adding unicode-ccc v0.2.0 (latest: v0.3.0)
      Adding usvg v0.42.0 (latest: v0.43.0)
      Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1)
      Adding which v4.4.2 (latest: v6.0.3)
      Adding windows v0.54.0 (latest: v0.58.0)
      Adding windows v0.56.0 (latest: v0.58.0)
      Adding windows-core v0.52.0 (latest: v0.58.0)
      Adding windows-core v0.54.0 (latest: v0.58.0)
      Adding windows-core v0.56.0 (latest: v0.58.0)
      Adding windows-implement v0.53.0 (latest: v0.58.0)
      Adding windows-implement v0.56.0 (latest: v0.58.0)
      Adding windows-interface v0.53.0 (latest: v0.58.0)
      Adding windows-interface v0.56.0 (latest: v0.58.0)
      Adding windows-result v0.1.2 (latest: v0.2.0)
      Adding windows-sys v0.45.0 (latest: v0.59.0)
      Adding windows-sys v0.48.0 (latest: v0.59.0)
      Adding windows-sys v0.52.0 (latest: v0.59.0)
      Adding windows-targets v0.42.2 (latest: v0.52.6)
      Adding windows-targets v0.48.5 (latest: v0.52.6)
      Adding windows_aarch64_gnullvm v0.42.2 (latest: v0.52.6)
      Adding windows_aarch64_gnullvm v0.48.5 (latest: v0.52.6)
      Adding windows_aarch64_msvc v0.42.2 (latest: v0.52.6)
      Adding windows_aarch64_msvc v0.48.5 (latest: v0.52.6)
      Adding windows_i686_gnu v0.42.2 (latest: v0.52.6)
      Adding windows_i686_gnu v0.48.5 (latest: v0.52.6)
      Adding windows_i686_msvc v0.42.2 (latest: v0.52.6)
      Adding windows_i686_msvc v0.48.5 (latest: v0.52.6)
      Adding windows_x86_64_gnu v0.42.2 (latest: v0.52.6)
      Adding windows_x86_64_gnu v0.48.5 (latest: v0.52.6)
      Adding windows_x86_64_gnullvm v0.42.2 (latest: v0.52.6)
      Adding windows_x86_64_gnullvm v0.48.5 (latest: v0.52.6)
      Adding windows_x86_64_msvc v0.42.2 (latest: v0.52.6)
      Adding windows_x86_64_msvc v0.48.5 (latest: v0.52.6)
      Adding winnow v0.5.40 (latest: v0.6.18)
      Adding xkbcommon v0.7.0 (latest: v0.8.0)
      Adding zbus v3.15.2 (latest: v4.4.0)
      Adding zbus_macros v3.15.2 (latest: v4.4.0)
      Adding zbus_names v2.6.1 (latest: v3.0.0)
      Adding zvariant v3.15.2 (latest: v4.2.0)
      Adding zvariant_derive v3.15.2 (latest: v4.2.0)
      Adding zvariant_utils v1.0.1 (latest: v2.1.0)
   Compiling proc-macro2 v1.0.86
   Compiling unicode-ident v1.0.12
   Compiling autocfg v1.3.0
   Compiling cfg-if v1.0.0
   Compiling libc v0.2.158
   Compiling portable-atomic v1.7.0
   Compiling critical-section v1.1.3
   Compiling log v0.4.22
   Compiling memchr v2.7.4
   Compiling shlex v1.3.0
   Compiling pkg-config v0.3.30
   Compiling bitflags v2.6.0
   Compiling version_check v0.9.5
   Compiling pin-project-lite v0.2.14
   Compiling libm v0.2.8
   Compiling byteorder v1.5.0
   Compiling thiserror v1.0.63
   Compiling smallvec v1.13.2
   Compiling bitflags v1.3.2
   Compiling arrayvec v0.7.6
   Compiling libloading v0.8.5
   Compiling hashbrown v0.14.5
   Compiling rustix v0.38.35
   Compiling linux-raw-sys v0.4.14
   Compiling equivalent v1.0.1
   Compiling cc v1.1.15
   Compiling toml_datetime v0.6.8
   Compiling dlib v0.5.2
   Compiling regex-syntax v0.8.4
   Compiling crossbeam-utils v0.8.20
   Compiling futures-core v0.3.30
   Compiling serde v1.0.209
   Compiling scoped-tls v1.0.1
   Compiling syn v1.0.109
   Compiling semver v1.0.23
   Compiling downcast-rs v1.2.1
   Compiling slab v0.4.9
   Compiling num-traits v0.2.19
   Compiling parking v2.2.0
   Compiling wayland-client v0.31.5
   Compiling once_cell v1.19.0
   Compiling cfg_aliases v0.2.1
   Compiling typenum v1.17.0
   Compiling generic-array v0.14.7
   Compiling aho-corasick v1.1.3
   Compiling quick-xml v0.34.0
   Compiling futures-io v0.3.30
   Compiling winnow v0.5.40
   Compiling wayland-sys v0.31.4
   Compiling adler2 v2.0.0
   Compiling indexmap v2.4.0
   Compiling miniz_oxide v0.8.0
   Compiling crc32fast v1.4.2
   Compiling static_assertions v1.1.0
   Compiling simd-adler32 v0.3.7
   Compiling quote v1.0.37
   Compiling fastrand v2.1.1
   Compiling concurrent-queue v2.5.0
   Compiling io-lifetimes v1.0.11
   Compiling syn v2.0.76
   Compiling event-listener v5.3.1
   Compiling float-cmp v0.9.0
   Compiling event-listener v2.5.3
   Compiling adler v1.0.2
   Compiling tracing-core v0.1.32
   Compiling flate2 v1.0.33
   Compiling event-listener-strategy v0.5.2
   Compiling miniz_oxide v0.7.4
   Compiling strict-num v0.1.1
   Compiling wayland-scanner v0.31.4
   Compiling fdeflate v0.3.4
   Compiling memoffset v0.7.1
   Compiling getrandom v0.2.15
   Compiling wayland-backend v0.3.6
   Compiling memmap2 v0.9.4
   Compiling polling v2.8.0
   Compiling futures-lite v2.3.0
   Compiling async-task v4.7.1
   Compiling fastrand v1.9.0
   Compiling waker-fn v1.2.0
   Compiling regex-automata v0.4.7
   Compiling arrayref v0.3.8
   Compiling khronos_api v3.1.0
   Compiling atomic-waker v1.1.2
   Compiling rustix v0.37.27
   Compiling futures-lite v1.13.0
   Compiling piper v0.2.4
   Compiling png v0.17.13
   Compiling rand_core v0.6.4
   Compiling toml_edit v0.19.15
   Compiling crypto-common v0.1.6
   Compiling block-buffer v0.10.4
   Compiling async-channel v2.3.1
   Compiling async-lock v2.8.0
   Compiling async-fs v1.6.0
   Compiling async-io v1.13.0
   Compiling ahash v0.8.11
   Compiling slotmap v1.0.7
   Compiling rustversion v1.0.17
   Compiling ttf-parser v0.21.1
   Compiling lazy_static v1.5.0
   Compiling linux-raw-sys v0.3.8
   Compiling tinyvec_macros v0.1.1
   Compiling tinyvec v1.8.0
   Compiling blocking v1.6.1
   Compiling digest v0.10.7
   Compiling socket2 v0.4.10
   Compiling xml-rs v0.8.21
   Compiling cpufeatures v0.2.13
   Compiling pin-utils v0.1.0
   Compiling futures-task v0.3.30
   Compiling futures-sink v0.3.30
   Compiling sha1 v0.10.6
   Compiling nix v0.26.4
   Compiling async-executor v1.13.0
   Compiling xdg-home v1.3.0
   Compiling async-broadcast v0.5.1
   Compiling rustc_version v0.4.1
   Compiling memoffset v0.9.1
   Compiling ordered-stream v0.2.0
   Compiling smithay-client-toolkit v0.19.2
   Compiling gl_generator v0.14.0
   Compiling as-raw-xcb-connection v1.0.1
   Compiling hex v0.4.3
   Compiling xkeysym v0.2.1
   Compiling heck v0.5.0
   Compiling roxmltree v0.20.0
   Compiling xcursor v0.3.8
   Compiling cursor-icon v1.1.0
   Compiling field-offset v0.3.6
   Compiling euclid v0.22.11
   Compiling x11-dl v2.21.0
   Compiling unicode-ccc v0.2.0
   Compiling proc-macro-crate v1.3.1
   Compiling unicode-xid v0.2.5
   Compiling unicode-script v0.5.6
   Compiling unicode-properties v0.1.2
   Compiling convert_case v0.4.0
   Compiling x11rb-protocol v0.13.1
   Compiling unicode-bidi-mirroring v0.2.0
   Compiling regex v1.10.6
   Compiling fontconfig-parser v0.5.7
   Compiling cpp_common v0.5.9
   Compiling zvariant_utils v1.0.1
   Compiling kurbo v0.11.0
   Compiling lyon_geom v1.0.5
   Compiling cpp_build v0.5.9
   Compiling unicode-bidi v0.3.15
   Compiling ttf-parser v0.24.1
   Compiling siphasher v1.0.1
   Compiling fontdb v0.18.0
   Compiling lyon_path v1.0.5
   Compiling simplecss v0.2.1
   Compiling svgtypes v0.15.2
   Compiling ab_glyph_rasterizer v0.1.8
   Compiling base64 v0.22.1
   Compiling xmlwriter v0.1.0
   Compiling unicode-vo v0.1.0
   Compiling data-url v0.3.1
   Compiling imagesize v0.12.0
   Compiling allocator-api2 v0.2.18
   Compiling pico-args v0.5.0
   Compiling raw-window-handle v0.6.2
   Compiling derive_utils v0.14.2
   Compiling glutin_egl_sys v0.7.0
   Compiling thiserror-impl v1.0.63
   Compiling bytemuck_derive v1.7.1
   Compiling tracing-attributes v0.1.27
   Compiling zerocopy-derive v0.7.35
   Compiling serde_derive v1.0.209
   Compiling enumflags2_derive v0.7.10
   Compiling zvariant_derive v3.15.2
   Compiling futures-macro v0.3.30
   Compiling zbus_macros v3.15.2
   Compiling derivative v2.2.0
   Compiling serde_repr v0.1.19
   Compiling async-trait v0.1.81
   Compiling async-recursion v1.1.1
   Compiling zerocopy v0.7.35
   Compiling bytemuck v1.17.1
   Compiling strum_macros v0.26.4
   Compiling wayland-csd-frame v0.3.0
   Compiling derive_more v0.99.18
   Compiling futures-util v0.3.30
   Compiling tiny-skia-path v0.11.4
   Compiling wayland-protocols v0.32.3
   Compiling tracing v0.1.40
   Compiling ppv-lite86 v0.2.20
   Compiling polling v3.7.3
   Compiling wayland-cursor v0.31.5
   Compiling calloop v0.13.0
   Compiling tiny-skia v0.11.4
   Compiling rand_chacha v0.3.1
   Compiling rand v0.8.5
   Compiling rustybuzz v0.14.1
   Compiling calloop-wayland-source v0.3.0
   Compiling rgb v0.8.48
   Compiling owned_ttf_parser v0.24.0
   Compiling const-field-offset-macro v0.1.5
   Compiling ab_glyph v0.2.28
   Compiling pin-project-internal v1.1.5
   Compiling qttypes v0.2.11
   Compiling vtable-macro v0.2.0
   Compiling glutin_glx_sys v0.6.0
   Compiling const-field-offset v0.1.5
   Compiling winit v0.30.5
   Compiling immutable-chunkmap v2.0.5
   Compiling winnow v0.6.18
   Compiling color_quant v1.1.0
   Compiling jpeg-decoder v0.3.1
   Compiling accesskit v0.16.0
   Compiling iana-time-zone v0.1.60
   Compiling unicode-segmentation v1.11.0
   Compiling stable_deref_trait v1.2.0
   Compiling vtable v0.2.0
   Compiling chrono v0.4.38
   Compiling usvg v0.42.0
   Compiling accesskit_consumer v0.24.0
   Compiling image v0.24.9
   Compiling pin-project v1.1.5
   Compiling i-slint-common v1.7.2
   Compiling fontdue v0.9.2
   Compiling strum v0.26.3
   Compiling lyon_extra v1.0.2
   Compiling auto_enums v0.8.6
   Compiling i-slint-core-macros v1.7.2
   Compiling lyon_algorithms v1.0.4
   Compiling xkbcommon-dl v0.4.2
   Compiling toml_edit v0.22.20
   Compiling integer-sqrt v0.1.5
   Compiling ogg_next_sys v0.1.3
   Compiling wayland-protocols-wlr v0.3.3
   Compiling wayland-protocols-plasma v0.3.3
   Compiling alsa-sys v0.3.1
   Compiling tiny-xlib v0.2.3
   Compiling glutin v0.32.0
   Compiling resvg v0.42.0
   Compiling dpi v0.1.1
   Compiling pin-weak v1.1.0
   Compiling clru v0.6.2
   Compiling scopeguard v1.2.0
   Compiling byteorder-lite v0.1.0
   Compiling scoped-tls-hkt v0.1.4
   Compiling percent-encoding v2.3.1
   Compiling enumflags2 v0.7.10
   Compiling unicode-linebreak v0.1.5
   Compiling smol_str v0.2.2
   Compiling zvariant v3.15.2
   Compiling i-slint-core v1.7.2
   Compiling image v0.25.2
   Compiling cpp_macros v0.5.9
   Compiling proc-macro-crate v3.2.0
   Compiling unicode-normalization v0.1.23
   Compiling i-slint-backend-qt v1.7.2
   Compiling sctk-adwaita v0.10.1
   Compiling softbuffer v0.4.5
   Compiling zbus_names v2.6.1
   Compiling x11rb v0.13.1
   Compiling glutin-winit v0.5.0
   Compiling zbus v3.15.2
   Compiling imgref v1.10.1
   Compiling lru v0.12.4
   Compiling fnv v1.0.7
   Compiling glow v0.13.1
   Compiling ctor-lite v0.1.0
   Compiling paste v1.0.15
   Compiling idna v0.5.0
   Compiling form_urlencoded v1.2.1
   Compiling num_enum_derive v0.7.3
   Compiling cpp v0.5.9
   Compiling smithay-clipboard v0.7.2
   Compiling aotuv_lancer_vorbis_sys v0.1.4
   Compiling i-slint-backend-winit v1.7.2
   Compiling termcolor v1.4.1
   Compiling femtovg v0.9.2
   Compiling text-size v1.1.1
   Compiling countme v3.0.1
   Compiling cpal v0.15.3
   Compiling codemap v0.1.3
   Compiling i-slint-compiler v1.7.2
   Compiling rustc-hash v1.1.0
   Compiling linked-hash-map v0.5.6
   Compiling either v1.13.0
   Compiling rowan v0.15.16
   Compiling linked_hash_set v0.1.4
   Compiling itertools v0.13.0
   Compiling codemap-diagnostic v0.1.2
   Compiling x11-clipboard v0.9.2
   Compiling copypasta v0.10.1
   Compiling i-slint-renderer-femtovg v1.7.2
   Compiling num_enum v0.7.3
   Compiling alsa v0.9.1
   Compiling url v2.5.2
   Compiling i-slint-backend-selector v1.7.2
   Compiling anyhow v1.0.86
   Compiling dasp_sample v0.11.0
   Compiling by_address v1.2.1
   Compiling rmp v0.8.14
   Compiling spin_on v0.1.1
   Compiling symphonia-core v0.5.4
   Compiling atspi-common v0.3.0
   Compiling serde_bytes v0.11.15
   Compiling errno v0.3.9
   Compiling lonelyradio_types v0.7.0 (/home/jasonyau/.cargo/git/checkouts/lonelyradio-efab59a1784c9607/29338f3/lonelyradio_types)
   Compiling rodio v0.19.0
   Compiling rmp-serde v1.3.0
   Compiling symphonia-codec-alac v0.5.4
   Compiling zune-core v0.4.12
   Compiling claxon v0.4.3
   Compiling zune-jpeg v0.4.13
   Compiling atspi-proxies v0.3.0
   Compiling accesskit_atspi_common v0.9.0
   Compiling atspi-connection v0.3.0
   Compiling atspi v0.19.0
   Compiling accesskit_unix v0.12.0
   Compiling vorbis_rs v0.5.4
   Compiling accesskit_winit v0.22.0
   Compiling monolib v0.7.0 (/home/jasonyau/.cargo/git/checkouts/lonelyradio-efab59a1784c9607/29338f3/monolib)
   Compiling slint-macros v1.7.2
   Compiling slint v1.7.2
   Compiling monoclient-s v0.7.0 (/home/jasonyau/.cargo/git/checkouts/lonelyradio-efab59a1784c9607/29338f3/monoclient-s)
error[E0433]: failed to resolve: use of undeclared crate or module `lonelyradio_types`
   --> monoclient-s/src/main.rs:146:14
    |
146 |                 encoder: lonelyradio_types::Encoder::Flac,
    |                          ^^^^^^^^^^^^^^^^^ use of undeclared crate or module `lonelyradio_types`

error[E0433]: failed to resolve: use of undeclared crate or module `lonelyradio_types`
   --> monoclient-s/src/main.rs:145:4
    |
145 |             lonelyradio_types::Settings {
    |             ^^^^^^^^^^^^^^^^^ use of undeclared crate or module `lonelyradio_types`
    |
help: consider importing this crate
    |
1   + use monolib::lonelyradio_types;
    |

For more information about this error, try `rustc --explain E0433`.
error: could not compile `monoclient-s` (bin "monoclient-s") due to 2 previous errors
error: failed to compile `monoclient-s v0.7.0 (https://github.com/ivabus/lonelyradio?tag=0.7.0#29338f32)`, intermediate artifacts can be found at `/tmp/cargo-install3NHoHk`.
To reuse those artifacts with a future compilation, set the environment variable `CARGO_TARGET_DIR` to that path.
ivabus commented 2 weeks ago

oh, sorry, committed a fix.

try installing with cargo install --git https://github.com/ivabus/lonelyradio monoclient-s

JasonSanDiego commented 1 week ago

That resolved it. I also found I needed to install libxkbcommon-x11-0 using apt and then I could run the app successfully.

It's not clear how to connect to the server. Is it supposed to be passed in the command line as a parameter? I don't see anywhere to enter server details.

I'm running on WSL2 with XLaunch (VcXsrv). I'm not sure if that's related, but the window sizing is really wonky. I can't resize the window (window edge controls appear but don't work). Maximizing works but not custom resizing. When I open the app, sometimes it shows in different sizes, only showing the gear image, sometimes showing the window as I would expect to see it.

image

JasonSanDiego commented 1 week ago

This is what I assume the window is supposed to look like, but it doesn't seem to consistently open like this.

image

ivabus commented 1 week ago

I think it is a WSL2-specific strange behavior. Could you try a native Windows version, built on CI https://github.com/ivabus/lonelyradio/releases/tag/0.7.1-pre12

JasonSanDiego commented 5 days ago

got it. Native build works now. I didn't realize you had a Windows build. That's great. I also found with recent tries in WSL2, I can resize the window. Also, I discovered the input field for entering the server connection details. Windows has the same invisible input field. Perhaps a label or different color would make it easier to see what is an input field?