ivadim / fruitnanny

Raspberry PI based baby monitor
136 stars 57 forks source link

Add microphone filtering #22

Closed rbray89 closed 4 years ago

rbray89 commented 4 years ago

This change introduces pulseaudio as a go-between for audio processing so that we can use the echo-cancel module to "clean up" the microphone. This is especially useful when white-noise machines are running in the background.

ivadim commented 4 years ago

Hi @rbray89 This looks awesome. I tried myself to setup filtering before using containers but configuration became too complex...

Can I ask you to fix small issues before I merge this?


it happens because working directory is outside of the current Docker file's directory... 
https://github.com/ivadim/fruitnanny/blob/ca810c75326beb8cf0347b066b9f6116bc1b446b/azure-pipelines.pr.yml#L29
https://github.com/ivadim/fruitnanny/blob/ca810c75326beb8cf0347b066b9f6116bc1b446b/azure-pipelines.yml#L36

I think you can just add `cd` to  `docker/$(stage.name)`
ivadim commented 4 years ago

@rbray89 thank you for the contribution 🙇 . I'll fix the build later