search

ivadomed / MetricsReloaded

A fork of the Project-MONAI/MetricsReloaded repo
Apache License 2.0
3 stars 0 forks source link

Add LesionCountWeightedByAssignment, RefLesionsCount, PredLesionsCount #6

Closed valosekj closed 2 months ago

valosekj commented 2 months ago

@naga-karthik lmk once the PR is ready for review

Resolves #4

naga-karthik commented 2 months ago

hey @valosekj it is now ready for review! (for some reason, I am unable to add you as a reviewer)

valosekj commented 2 months ago

Thanks @naga-karthik! Tested and LGTM! I have just fixed a mission comma in https://github.com/ivadomed/MetricsReloaded/pull/6/commits/7f413e8a5881fe060f31cac9532b39e15811fc77. And clarified some comments in my other commits. I also added ref_count and pred_count to unit tests in https://github.com/ivadomed/MetricsReloaded/pull/6/commits/3dc77ca6d89ddebb3ab62fdf49189528f1cd0e0a. And added tests for multiple lesions in https://github.com/ivadomed/MetricsReloaded/pull/6/commits/e6c6596e5e65e5a49be3ff62506a6013e384d412. Finally, I also fixed the CI in https://github.com/ivadomed/MetricsReloaded/pull/6/commits/52b69f85f2e17cd2c127ca8a4d2039b57635ecf0!

naga-karthik commented 2 months ago

looks good ; merging!