search

ivadomed / model_seg_ms_mp2rage

Model repository for MS lesion segmentation on MP2RAGE data from University of Basel
MIT License
2 stars 0 forks source link

Release `r20230210` has changed the model name (missing `ms_`) #69

Open joshuacwnewton opened 1 year ago

joshuacwnewton commented 1 year ago

Between the last release and this new draft release, the name of the model was subtly changed from model_seg_ms_lesion_mp2rage to model_seg_lesion_mp2rage.

Before: ![image](https://user-images.githubusercontent.com/16181459/218870198-ce1a94e8-4ef0-428d-860f-a3ccdc173510.png) After: ![image](https://user-images.githubusercontent.com/16181459/218869751-fcca253e-ad8a-45f3-82f5-f18faf7fd6e7.png)

This means that, on SCT's end, we need to change the name of the existing entry for model_seg_ms_lesion_mp2rage, since it no longer matches the model name:

https://github.com/spinalcordtoolbox/spinalcordtoolbox/blob/aef83eb1482ea9360065ac8d8913aaf18edd4ce8/spinalcordtoolbox/deepseg/models.py#L90

I can work around this, but ideally we would keep the names consistent between releases.