search

ivaldi / brimir

Email helpdesk built using Ruby on Rails and Zurb Foundation
http://getbrimir.com
GNU Affero General Public License v3.0
1.38k stars 299 forks source link

feature: ui to rename ticket #372

Closed fiedl closed 7 years ago

fiedl commented 7 years ago

Sometimes, clients need a little help naming their tickets. This pull request adds a small button to rename the ticket. Renaming the ticket will create a status reply in the ticket history, but won't send a notification.

bildschirmfoto 2017-06-12 um 17 58 29 bildschirmfoto 2017-06-12 um 17 58 56 bildschirmfoto 2017-06-12 um 17 59 09

We have this in production since today. I'm going to report here in a couple of days if we encounter any issues.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.3%) to 92.331% when pulling dcfe780850c33c9f44c85650d4548041f0d05cac on fiedl:sf/change_subject into eb17775b319798fab04031d661933824f57e4e5d on ivaldi:master.

frenkel commented 7 years ago

Looks great! Thanks again. Let me know when you think it's ready to be merged.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.3%) to 92.331% when pulling 401f8e4f756cd4a18eb742b69ffd0446bc5ef28e on fiedl:sf/change_subject into eb17775b319798fab04031d661933824f57e4e5d on ivaldi:master.

fiedl commented 7 years ago

@frenkel We've had this in production for a couple of weeks, now. Everything works fine. I think this is ready for merging.

frenkel commented 7 years ago

Great! Do you want to add CHANGELOG entry in this PR? Or should I do it for you?

fiedl commented 7 years ago

I'd prefer if you would keep doing that.

frenkel commented 7 years ago

Sure, no problem