search

ivaldi / brimir

Email helpdesk built using Ruby on Rails and Zurb Foundation
http://getbrimir.com
GNU Affero General Public License v3.0
1.38k stars 299 forks source link

add checkbox to disables user. #387

Closed fkonigy closed 6 years ago

fkonigy commented 6 years ago

add related checkbox in users page for searchinf. refactored to display only active user. updated english locale. updated readme file.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.3%) to 92.064% when pulling 2e4b6d509aacabd44a05e47b0f872aaee6c08d14 on fkonigy:ability_to_disable_users into 54c911a2e2c87d55a36333b3d1f9f95ae340cfa5 on ivaldi:master.

frenkel commented 6 years ago

Looks OK, but please rename the field to active. I believe boolean variables in Rails should use these conventions: https://stackoverflow.com/questions/37059547/naming-conventions-for-boolean-attributes#37060624

fkonigy commented 6 years ago

@frenkel Ok renamed it to active. I thought devise requires it to be named is_active, but it works fine.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.3%) to 92.064% when pulling 3bfa197534fd5f3a7e8d6bcf243c2c72b299337e on fkonigy:ability_to_disable_users into 54c911a2e2c87d55a36333b3d1f9f95ae340cfa5 on ivaldi:master.