Update to rails 5.1 - Githubissues

ivaldi / brimir

Email helpdesk built using Ruby on Rails and Zurb Foundation

http://getbrimir.com

GNU Affero General Public License v3.0

1.38k stars 299 forks source link

Update to rails 5.1 #420

Closed lostapathy closed 6 years ago

lostapathy commented 6 years ago

Updating since Rails 5.0 no longer receives security updates

This builds on #418 and upgrades to Rails 5.1, fixes test errors, and resolves all deprecation warnings. I also updated Gemfile.lock to allow a few other gems to update as well.

I will try to follow up on an upgrade to 5.2 in the future, but at present there is an issue with at least one gem (Trix) that has patches waiting for proper 5.2 compatibility.

coveralls commented 6 years ago

Coverage increased (+0.003%) to 92.382% when pulling 9f2465ee0684464f39b5b2ae864da5ee61749fdf on lostapathy:update_rails2 into ebb116d880d814894781e1b17f8ae55f465cff3c on ivaldi:master.

frenkel commented 6 years ago

Great work! There are some conflicts in this PR though and the Travis build fails. Could you fix that?

lostapathy commented 6 years ago

Sorry about that @frenkel - of course my other PRs would have a merge conflict!

That's fixed and Travis is green now - I think the prior failure was actually a Travis hiccup, not a real problem.