search

ivaldi / brimir

Email helpdesk built using Ruby on Rails and Zurb Foundation
http://getbrimir.com
GNU Affero General Public License v3.0
1.38k stars 299 forks source link

Paperclip and test suite update #457

Closed jamgregory closed 5 years ago

jamgregory commented 5 years ago

I've updated Paperclip to the latest version (although it is now deprecated and no longer supported). I'm hoping this might fix some local issues we've been having with attachments, although I need to try and replicate these issues locally on development.

I've also added a more specific test for attaching JPEGs, as the current test only appears to check if PDFs can be attached.

I've noticed that all tests regarding attachments (certainly for PDFs) don't appear to work on Ubuntu 16.04 - this may be an incompatibility with ImageMagick, Ghostscript or something else. The tests appear to run (and pass) on Ubuntu 14.04 on Travis, but I don't know if there's an option to try newer VMs (Ubuntu 14.04 goes EOL in March 2019).

frenkel commented 5 years ago

Thanks!

coveralls commented 5 years ago

Coverage Status

Coverage decreased (-1.04%) to 89.502% when pulling 0b957442147e63e8006dd1663a09db87db703c90 on epigenesys:paperclip-updates into 32e6ccc66d38d3a612d59dcac58c055ced37d7bd on ivaldi:master.