ivalkou / freeaps

FreeAPS X - an artificial pancreas system for iOS based on OpenAPS
MIT License
162 stars 141 forks source link

Allow insulin delivery until empty pod reservoir #184

Closed Jon-b-m closed 2 years ago

Jon-b-m commented 2 years ago

There are 4 units reserve capacity in pods. This allows insulin delivery until pod reservoir is fully empty / screaming.

ivalkou commented 2 years ago

This check is meaningless and will always succeed because there are no negative values. If you still need such a feature, please bring it to the settings.

Jon-b-m commented 2 years ago

OK. The intention was to be able to Loop until pod screams/is completely empty. I borrowed this "fix" from loopnlearn. I'm not certain then how to accomplish this.

alphastrem commented 2 years ago

Maybe add 5u to the actual amount so when the true value hits zero the app reads as 5u still avail and keeps delivering?

Prob easier than allowing delivery into negative figures?

On 14 Mar 2022, at 11:38, Jon B Mårtensson @.***> wrote:



OK. The intention was to be able to Loop until pod screams/is completely empty. I borrowed this "fix" from loopnlearn. I'm not certain then how to accomplish this.

— Reply to this email directly, view it on GitHubhttps://github.com/ivalkou/freeaps/pull/184#issuecomment-1066966810, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AIQ5KMFSQREAH67R2JFKXR3U75MQBANCNFSM5P2SJ4VA. You are receiving this because you are subscribed to this thread.Message ID: @.***>

Jon-b-m commented 2 years ago

Yes, or maybe 4U when using Omnipod as a pump, so that the count (+4) is actually accurate.

bjornoleh commented 2 years ago

My understanding is that there is some insulin, up to around 4 U left when the reservoir is reported as empty. But that the exact amount is not known or guaranteed. Perhaps @marionbarker can comment briefly on this.

Not sure if this detail matters for this PR though.