Fix incorrect archiving of unmatched incomplete tasks - Githubissues

ivan-lednev / obsidian-task-archiver

Archive completed tasks in your Obsidian vault (plus other org-mode-like features)

MIT License

116 stars 12 forks source link

Fix incorrect archiving of unmatched incomplete tasks #89

Open byjo opened 8 months ago

byjo commented 8 months ago

Resolves #88 (The problem is detailed in this issue)

Changes Made

Make doesRuleMatch function for a more consistent rule evaluation throughout the application. (https://github.com/ivan-lednev/obsidian-task-archiver/commit/a31011be218e8d4e3a709af52e306f4fe464b9ab)
- ArchiveFeature, TaskTestService use this new integrated function (https://github.com/ivan-lednev/obsidian-task-archiver/commit/cbe47208668a3fb7e39473b544d6f38a6875aa23, https://github.com/ivan-lednev/obsidian-task-archiver/commit/f5aedf21632a0b55b2e141fc12cf23e655d859fb)
Modified the logic in doesRuleMatchTaskStatus function to ensure that it accurately checks (https://github.com/ivan-lednev/obsidian-task-archiver/commit/426f122d2ac0257d2ab9ea799936eb371c35785a)

Additional Information

Please review the updated function and feature implementation for any potential impacts on other areas of the application.
I am open to feedback and will earnestly incorporate any suggestions or improvements recommended during the review process. 😄

ivan-lednev commented 8 months ago

Hello, @byjo,

Thank you for the effort you've put into identifying the issue and fixing it! I haven't touched those parts of the plugin in a while, so instead of my memory I rely on automated tests to see if the change broke something else. I see that all the tests are passing fine.

Aside from comments that I left, please add a test that fails without your change and passes with it. Once you do that and fix the comments, I think we're good to go 🚀