search

ivan-liadniou-epam / obsidian-day-planner-fork

This fork got merged into the original, so that's a good place to create issues: https://github.com/ivan-lednev/obsidian-day-planner
MIT License
58 stars 2 forks source link

:sparkles: Update task.svelte to honour theme styling #18

Closed sigrunixia closed 1 year ago

sigrunixia commented 1 year ago

This is a minor tweak that should fix the link styling with certain themes. I added minor font weight increases as well for readability in the cases where the accent-text is more muted.

This should close #12.

sigrunixia commented 1 year ago

Note: I am having a hard time getting a dev environment working with the current setup. I had to update esbuild and esbuild sass dependencies in package.json on my end to get it going. However, it seems like esbuild does not like much of what is happening in Svelte and complains of depreciated features. This goes past my knowledge of "correcting it" however. A check of what dependencies are needed may be needed, and I can open an issue for that if you wish.

sigrunixia commented 1 year ago

Also, I dont think styles.scss needs updated with this since this is attempting to make these changes baseline. If it does, however, I can add that to this PR.

ivan-lednev commented 1 year ago

Hello, @sigrunixia!

Thank you for taking the time to contribute! It's really inspiring when other people want to collaborate with you on your projects ❤️

This is a minor tweak that should fix the link styling with certain themes.

Unknowingly, I added a different fix for the issue with colors. Check out 0.3.0 and tell me what you think.

I've fixed the installation issue and added a guide on how to develop the plugin locally: https://github.com/ivan-lednev/obsidian-day-planner/commit/15363be851fbfd2ef6b27108e260be5e304486b1

When it comes to styling, I try to make it as similar to Obsidian's own styles as possible. If you'd like to customize that (make things look different from the default theme), I think a better approach is to add those styles to settings. You might create a separate issue for that or submit a PR.

sigrunixia commented 1 year ago

Hello, @sigrunixia!

Thank you for taking the time to contribute! It's really inspiring when other people want to collaborate with you on your projects ❤️

This is a minor tweak that should fix the link styling with certain themes.

Unknowingly, I added a different fix for the issue with colors. Check out 0.3.0 and tell me what you think.

I've fixed the installation issue and added a guide on how to develop the plugin locally: 15363be

When it comes to styling, I try to make it as similar to Obsidian's own styles as possible. If you'd like to customize that (make things look different from the default theme), I think a better approach is to add those styles to settings. You might create a separate issue for that or submit a PR.

Thanks for the development guide. That will help out in the next PR. :)

It looks like your fix solves the issue and does it in a better way than I could (mainly due to my still learning svelte). So I will go ahead and close this PR as it is not redundant. I agree with the philosophy, that sticking as close to Obsidian use of classes is better than not.