search

ivan-m / haskell-docs

Get the Haskell documentation of a name from a module
BSD 3-Clause "New" or "Revised" License
32 stars 8 forks source link

Fixed descendSearch: the package being searched should not be ignored wh... #21

Closed jaccokrijnen closed 9 years ago

jaccokrijnen commented 9 years ago

...en looking at re-exported modules

This solves https://github.com/chrisdone/haskell-docs/issues/20 for me.

chrisdone commented 9 years ago

I suspect this may prevent cross-package re-exports.

jaccokrijnen commented 9 years ago

It seems to me that descendSearch excludes the package by giving Just package to searchModuleIdent, which in turn filters it from the packages to search (therefore failing when a different module of the same package has to be searched). I don't really see how that would influence cross-package re-exports?

chrisdone commented 9 years ago

If a re-export needs to descend into a different package but you've specified (Just onlyLookInThisPackage)?

jaccokrijnen commented 9 years ago

But searchModuleIdent looks at every package with the given module name (except for the one provided), right?

chrisdone commented 9 years ago

Ah, you're correct. filterPrevious is a misnomer (filter = "keep these", but filterPrevious = "exclude these"). I'll rename it.

chrisdone commented 9 years ago

Merged.

chrisdone commented 9 years ago

Bumped as 4.2.5. Thanks!