ivan-usov / BrainSoundLab

Processing and visualization of neurophysiological data
http://www.brainsoundlab.com/
2 stars 2 forks source link

Correcting the calculation of trf_rate for AMS #8

Closed taniabarkat closed 8 years ago

taniabarkat commented 8 years ago

trf_rate is not calculating correctly because the function block.calcSweepTime() (called in line 53 in process.calcTuningCruves.m) is not adapted for AMS (it is though correct for FMS). The calculation of trf_num is correct for both AMS and FMS.

ivan-usov commented 8 years ago

Indeed, the sweep time should have been directly extracted from the second stimulus condition in AMS experiments

taniabarkat commented 8 years ago

Thank you Ivan. I checked the new code. We just need to add the abs value of experiment.AMS.m line 32:

sweepTime = abs(this.stimConditions(:, 2)/1000);

And then it is all fixed.

Let me know if you want me to make that change – but I guess that as it is your repository you should do it.

Have a good start fo the week Best


Tania Rinaldi Barkat Assistant Professor in Neurophysiology

Basel University Department of Biomedicine, room 7001 Klingelbergstrasse 50-70 4056 Basel Switzerland

+41 61 267 1638 www.brainsoundlab.com

From: Ivan Usov notifications@github.com<mailto:notifications@github.com> Reply-To: ivan-usov/BrainSoundLab reply@reply.github.com<mailto:reply@reply.github.com> Date: Sunday 25 September 2016 13:58 To: ivan-usov/BrainSoundLab BrainSoundLab@noreply.github.com<mailto:BrainSoundLab@noreply.github.com> Cc: Tania Barkat tania.barkat@unibas.ch<mailto:tania.barkat@unibas.ch>, Author author@noreply.github.com<mailto:author@noreply.github.com> Subject: Re: [ivan-usov/BrainSoundLab] Correcting the calculation of trf_rate for AMS (#8)

Indeed, the sweep time should be directly extracted from the second stimulus condition in AMS experiments

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/ivan-usov/BrainSoundLab/issues/8#issuecomment-249417642, or mute the threadhttps://github.com/notifications/unsubscribe-auth/APSn_Hp91VvwSuNIC_XdBeGB4ELKWo4kks5qtmHkgaJpZM4KFBpb.

ivan-usov commented 8 years ago

I added abs(...) in 7e47c8f, so you don't need to change anything