ivan-zapreev / Distributed-Translation-Infrastructure

The distributed statistical machine translation infrastructure consisting of load balancing, text pre/post-processing and translation services. Written in C++ 11 and utilises multicore CPUs by employing multi-threading, allows for secure SSL/TLS communications.
GNU General Public License v2.0
12 stars 3 forks source link

More detail on requirements for tuning #11

Closed jamesdbaker closed 6 years ago

jamesdbaker commented 6 years ago

Expand instructions to explicitly state the requirement for compiling bpbd-server in tuning mode when running the tuning scripts (which is obvious when you know, but worth restating to avoid Issue #10).

ivan-zapreev commented 6 years ago

By the way, James, there is a warning generated by the bpbd-server when it is compiled in non-tuning mode but the 'de_is_gen_lattice' parameter is set to true: WARN: The de_is_gen_lattice is set to true in a non-training mode server compilation, re-setting to false! When run from the tuning script this is indeed not seen, so I was wondering, if this shall be turned into an error. In this case, it might be more vivid for the user. What is your opinion on that?

jamesdbaker commented 6 years ago

That makes sense to me. I think it would be preferable to throw an error and make the user change the configuration manually, rather than fix it quietly behind the scenes and the user not realising something was wrong/has been changed.