search

ivan-zapreev / Distributed-Translation-Infrastructure

The distributed statistical machine translation infrastructure consisting of load balancing, text pre/post-processing and translation services. Written in C++ 11 and utilises multicore CPUs by employing multi-threading, allows for secure SSL/TLS communications.
GNU General Public License v2.0
12 stars 3 forks source link

Parse error in tuning scripts (bpbd-client) #19

Closed jamesdbaker closed 5 years ago

jamesdbaker commented 5 years ago

https://github.com/ivan-zapreev/Distributed-Translation-Infrastructure/blob/d6e3084f5b47713a0768a3f1a44cebe1d3c0fd44/script/tuning/scripts/start_infra.sh#L88

I've just done a fresh build of REMEDI 1.8.2 and tried to run the tuning scripts, and this line seems to be causing the following error:

PARSE ERROR: Argument: -t
             Couldn't find match for argument

Brief USAGE: 
   /opt/build/Distributed-Translation-Infrastructure/script/tuning/scripts/
                                        ../../../build/bpbd-client  [-d
                                        <error|warn|usage|result|info|info1
                                        |info2|info3>] [-c <client
                                        configuration file>] [-f] [-s <the
                                        translation priority>] [-u <max
                                        #sentences per request>] [-l <min
                                        #sentences per request>] [-o
                                        <target language>] -O <target file
                                        name> -i <source language> -I
                                        <source file name> [--] [--version]
                                        [-h]

For complete USAGE and HELP type: 
   /opt/build/Distributed-Translation-Infrastructure/script/tuning/scripts/../../../build/bpbd-client --help

I thought I did have this working previously, so is there something that would have caused this to start happening?

ivan-zapreev commented 5 years ago

Dear James,

"-t" does not seem to be an existing parameter option for the "bpbd-client". It looks like it was remoed on the 29 of May https://github.com/ivan-zapreev/Distributed-Translation-Infrastructure/commit/2abc248b86219d747567ccb86be122fc910abc85#diff-e9759bd58f5b19e4c73bc0cafdc4bd1c and the configuration is now to be specified from the config file.

It might be a good idea to bring this option back. I shall look into that.

Kind regards,

Ivan

jamesdbaker commented 5 years ago

Thanks Ivan, I just worked out that it was missing (I must have been using an old version previously!)

I'm just testing a fix to bring it back here: https://github.com/jamesdbaker/Distributed-Translation-Infrastructure/tree/server_config

Once tested, I'll submit a PR.

ivan-zapreev commented 5 years ago

Dear James,

I am not sure yet of what is the best way t deal with this. The idea was to put all the configurations into the client-related config files. If we bring the client's -t option back then it has to be identified what shall be leading, the config file or the command line option. As far as I remember the trend was to allow the command line option to overrule the config file's one.

Kind regards,

Ivan

On Thu, Nov 29, 2018 at 12:06 PM jamesdbaker notifications@github.com wrote:

Thanks Ivan, I just worked out that it was missing (I must have been using an old version previously!)

I'm just testing a fix to bring it back here: https://github.com/jamesdbaker/Distributed-Translation-Infrastructure/tree/server_config

Once tested, I'll submit a PR.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/ivan-zapreev/Distributed-Translation-Infrastructure/issues/19#issuecomment-442794941, or mute the thread https://github.com/notifications/unsubscribe-auth/AKH_HeAWfMlqe0QGmhiSt5vgL7d9HlMYks5uz7_EgaJpZM4Y5ZIl .

-- Best regards,

Dr. Ivan S. Zapreev http://www.tainichok.ru/

jamesdbaker commented 5 years ago

I've now made it override the configuration file if both are provided, in line with the existing options that can be duplicated in the command line and configuration.

ivan-zapreev commented 5 years ago

Sounds great! Thank you!

On Thu, Nov 29, 2018, 12:20 jamesdbaker <notifications@github.com wrote:

I've now made it override the configuration file if both are provided, in line with the existing options that can be duplicated in the command line and configuration.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/ivan-zapreev/Distributed-Translation-Infrastructure/issues/19#issuecomment-442798293, or mute the thread https://github.com/notifications/unsubscribe-auth/AKH_HevujMzWZ-Jx_JotAJlFOXZtT3fLks5uz8LhgaJpZM4Y5ZIl .