search

ivan24004 / pe

0 stars 0 forks source link

Incorrect maximum number of periods in a day #11

Open ivan24004 opened 5 months ago

ivan24004 commented 5 months ago

image.png It is mentioned that there are 0-24 possible periods in a day, but there is no case where 24 is a possible number of periods. Even if you have 0-1, 1-2, ..., 22-23, there are still only 23 slots (note 23-24 is impossible to have since 24 isn't allowed)

nus-pe-bot commented 5 months ago

Team's Response

But yes, documentation error, should be 23 maximum allowable periods.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Impossible to specify certain timings

image.png

Although unlikely for classes to occur during midnight, it seems impossible to specify a class that starts at 10pm and ends at 12mn, how do you differentiate this from a class that starts at 10pm and ends at 11pm?

[original: nus-cs2103-AY2324S2/pe-interim#2856] [original labels: severity.Low type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Rare for classes to run until midnight, UG and application stated that valid inputs are 0-23

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.DocumentationBug`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]