search

ivan24004 / pe

0 stars 0 forks source link

Incorrect activation bar #12

Open ivan24004 opened 5 months ago

ivan24004 commented 5 months ago

image.png

ListComandParser::parse's activation bar is too short, it should end when I is returned

nus-se-bot commented 5 months ago

Team's Response

Cosmetic issue. This would not cause a misunderstanding for developers reading the DG.

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Medium]

Reason for disagreement: This is not merely a cosmetic issue, it is an error in diagramming that at the worst case, leaves room for ambiguity.

It could be interpreted as an activation bar that is too short, but it may also be interpreted as the activation bar being at the right place, the return arrow being omitted, and a new activation bar that covers ListCommand(true) and its return, with an arrow that points to that activation bar. Essentially, a new function call, this leaves enough ambiguity in the diagram for it to no longer be considered a cosmetic issue, and thus severity.VeryLow is not a sensible severity for this.