search

ivan24004 / pe

0 stars 0 forks source link

The lifetime of ListCommand is incorrect #13

Open ivan24004 opened 3 months ago

ivan24004 commented 3 months ago

image.png

ListCommand should be destroyed once LogicManager::execute ends

nus-pe-bot commented 3 months ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Incorrect activation bar

Note from the teaching team: This bug was reported during the Part II (Evaluating Documents) stage of the PE. You may reject this bug if it is not related to the quality of documentation.

image.png

ListComandParser::parse's activation bar is too short, it should end when I is returned

[original: nus-cs2103-AY2324S2/pe-interim#2864] [original labels: severity.Medium type.DocumentationBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Cosmetic issue. This would not cause a misunderstanding for developers reading the DG.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: These are 2 separate issues, one pertains to the activation bar and the other pertains to lifetimes. They can't be solved together either, you need to add a lifetime and extend the activation bar in order for the issue to be corrected. Thus, they cannot be marked as duplicates.

## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Low`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]