search

ivan24004 / pe

0 stars 0 forks source link

Slots command has uninteded behaviour #7

Open ivan24004 opened 3 months ago

ivan24004 commented 3 months ago

Steps to reproduce: list timetable slots t/tutorial-1 image.png

Runs successfully , even if no duration parameter is given to slots, no error message is given. It also just causes the list to change, as if I was using the find command.

soc-pe-bot commented 3 months ago

Team's Response

Does not affect usage, rare case where the user uses the slot command outside of its intended purpose.

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: This is not a rare use-case, it is fairly common for required fields to be left missing, and the app should be able to handle that by giving an informative error message.

Reference from UG for the format of slots command:

Format : slots d/DURATION [t/TAG] [p/PERIOD] [o/DAYS]

In this case, the app doesn't provide any feedback (the message from the previous command stays there). It also does something that is not documented at all, it changes the student list based on the tag given. This is enough to moderately inconvenience users who unknowingly forgot to put the d/DURATION segment and require a decent amount of effort for them to spot (given that they unknowingly forgot to put the d/DURATION segment).