ivanaitzliddat / pe

0 stars 0 forks source link

Accepting full notations for category in add function in study manager #18

Open ivanaitzliddat opened 2 years ago

ivanaitzliddat commented 2 years ago

User Guide says that it accepts shorthand notations, but does not mention that it does not accept the normal notations.

image.png

image.png

soc-se-bot commented 2 years ago

Team's Response

The UG mentions what is accepted under the constraints. It is not necessary to mention all the things that are not accepted as that could be a much longer list if we were to list every possible invalid input.

This is similar for the module code constraint, when we say "accepted inputs are alphanumeric parameters", it, by default implies that special characters are not accepted.

Category only accepts shorthand notations which are one of lec, tut, lab or exam. It is already implied that normal notations and other values are not accepted. This has further been clarified by the error message in case it was unclear in the user guide. Intended feature and not a valid bug or FeatureFlaw.

Our intended feature is to only accept shorthand notations to save user typing effort. However, internally the entry will be converted to their normal longer notations such as Lecture, Tutorial, Laboratory and Exam. There is no need to type the full notation as there are appropriate shorthands for each possible value in category.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: As mentioned in one of the replies by your team, the application should not reject overzealous user inputs. If user input lecture instead of lec, it should not be rejected. Hence it is still considered a bug.

image.png


:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Low]

Reason for disagreement: This is not a cosmetic issue