ivanceras / curtain

Moved to https://github.com/ivanceras/diwata
https://github.com/ivanceras/diwata
Apache License 2.0
141 stars 4 forks source link

Put proper error messages when deleting records #3

Open breinjhel opened 7 years ago

breinjhel commented 7 years ago
--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/39316448-put-proper-error-messages-when-deleting-records?utm_campaign=plugin&utm_content=tracker%2F28555874&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F28555874&utm_medium=issues&utm_source=github).
jmealo commented 7 years ago

@breinjhel: Can you flesh this out?

ivanceras commented 7 years ago

Yep, some records that are selected for deleting are not deleted. I haven't looked into the details, but this comes down to the filter parser which I am currently rewriting the library to use nom instead of peg parser.

jmealo commented 7 years ago

@ivanceras I'm not sure if this is relevant, but, PostgREST has a pretty nice way of passing filters/quals via query parameters. Reading the tickets and Gitter is helpful to see what real use cases look like for REST consumers. I guess you have more control here, but, there's no reason the backend for curtain couldn't be used independently of curtain. Is this outside of the scope of what you were planning?

ivanceras commented 7 years ago

Yes, PostgREST is relevant, in fact I even wrote it in my rest filter parser project (https://github.com/ivanceras/inquerest) as inspired by PostgREST. If I go the route of using PostgREST as the backend, then what's left will be the front-end which is written in elm. The plan is not to be limited by PostgreSQL alone, I also want to support SQLite, MySQL, etc.