search

ivanceras / svgbob

Convert your ascii diagram scribbles into happy little SVG
http://ivanceras.github.io/svgbob-editor/
Apache License 2.0
3.91k stars 112 forks source link

"Other example" doesn't link up rounded corners correctly #36

Closed tabatkins closed 5 years ago

tabatkins commented 5 years ago

The "Other Example" you provide has a lot of shapes that don't connect properly, like:

           .-.      
          |   |     
       .---------.  
      |           | 
       '---------'  
          |   |     
           '-'

In this example, the ends of both lozenges don't connect to their sides; you instead have to widen things so they connect:

          .---.      
          |   |     
      .-----------.  
      |           | 
      '-----------'  
          |   |     
          '---'

I'm not sure if this is intended behavior or not, but it affects a lot of images in this example page, so I assume it must have worked at some point.

tabatkins commented 5 years ago

Hmm, given the "Mixed Rounded & Square Corners" example, I'm assuming that the extra-separated version was intended to be recognized as a rounder corner.

ivanceras commented 5 years ago

The rounded corner is using the ' , . and ' while sharp corner is using + . First example has far more separate distance which requires a bit more of explicit behavior, therefore it is not sought. The examples are not yet adjusted yet.