ivanceras / svgbob

Convert your ascii diagram scribbles into happy little SVG
http://ivanceras.github.io/svgbob-editor/
Apache License 2.0
3.83k stars 108 forks source link

Rendering regression #82

Open PHHENS opened 2 years ago

PHHENS commented 2 years ago

Basic shape which rendered well with a previous version, now gives strange rendering :

 .---------.
 |.-..----.|
 || ||    ||
 || ||    ||
 |'-''----'|
 '---------'

gives image instead (worked in a previous version) image

Can you please help ? Thanks

ivanceras commented 2 years ago

This makes sense, due to the addition of a feature to match bigger rounded corner. Take a look at this 3 variant example. The 3rd variant can create rounded rectangles with a bigger radius on the corners, but as a side effect, using it in the 1st figure produces this artifact as those combination is also valid and logical. I don't have a fix for this at the moment, this may require a core overhaul such as prioritizing the closest match and ignoring the matches in which characters are farther than first match. As a work around, perhaps add spacing to the figures such as in the 2nd example to prevent this artifact for now.

 .---------.
 |.-..----.|
 || ||    ||
 || ||    ||
 |'-''----'|
 '---------'

 .------------.
 | .-. .----. |
 | | | |    | |
 | | | |    | |
 | '-' '----' |
 '------------'

  .----------.
 | .-.  .--.  |
 | | | |    | |
 | | | |    | |
 | '-'  '--'  |
  '----------'
PHHENS commented 2 years ago

Dear Ivan,

First of all, thanks for your great work and for answering to my issue. I think svgbob is great, so that I use it intensely since a few weeks ;-)

I've drawed a sort of icon library, that I use for building schematics. I applied a rule self defined rule  "the more compact, the better",  so adding spaces breaks it ;-)

Maybe a solution for larger rounded corner : use two .. and two '' like in the example below :

.----------. ..----------.. | .-. .--. | | .-. ..--.. | | | | | | | --\ | | | | | | | | | | | | --/ | | | | | | | '-' '--' | | '-' ''--'' | '----------' ''----------''

Thanks

Le mardi 05 octobre 2021 à 04:17 -0700, Jovansonlee Cesar a écrit :

This makes sense, due to the addition of a feature to match bigger rounded corner. Take a look at this 3 variant example. The 3rd variant can create rounded rectangles with a bigger radius on the corners, but as a side effect, using it in the 1st figure produces this artifact as those combination is also valid and logical. I don't have a fix for this at the moment, this may require a core overhaul such as prioritizing the closest match and ignoring the matches in which characters are farther than first match. As a work around, perhaps add spacing to the figures such as in the 2nd example to prevent this artifact for now.  .---------.  |.-..----.|  || || ||  || || ||  |'-''----'|  '---------'

 .------------.  | .-. .----. |  | | | | | |  | | | | | |  | '-' '----' |  '------------'

  .----------.  | .-. .--. |  | | | | | |  | | | | | |  | '-' '--' |   '----------' — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.