Closed antoniusmisfit closed 6 years ago
I don't know how it is with Void, but there is no such problem on Ubuntu. Have you tried installing mkisofs
instead of genisoimage
on Void? Setting up your own development environment is entirely up to you. The ISO image generation process should work fine with any of these:
mkisofs
genisoimage
xorriso
It is OK to introduce xorriso
but please update the corresponding README
section where the dependencies are described. The xorriso
package has to be added and the genisoimage
package has to be removed. Also, when you use xorriso
in general you don't need -r
, -R
and -input-charset
.
I'll update the README.
I apparently do have mkisofs installed on Void but so far I can't locate which package it came from.
In that case all you need to do in your environment is to change the genisoimage
invocation with mkisofs
and it should work fine.
Is the indentation all good now?
In general, each pull request should follow the same structure and code/indentation style as in the original code. In this way the repository maintainer (in this case this is me) will have less overhead to deal with. This is general rule for all open source projects.
Some of the lines in your code are still not indented as in the original code. Please double check all your changes and implement the indentation according to the original style that has been used.
Since I switched from Ubuntu to Void Linux, building MLS kept failing because there's no genisoimage package available for Void. Seems you forgot to copy over the xorriso command from MLL to this, so I fixed that.