ivandavidov / minimal-linux-script

One script which generates live Linux ISO image with minimal effort. Based on the first published version of Minimal Linux Live: http://github.com/ivandavidov/minimal
GNU General Public License v3.0
224 stars 70 forks source link

Replaced genisoimage with xorriso command #5

Closed antoniusmisfit closed 6 years ago

antoniusmisfit commented 6 years ago

Since I switched from Ubuntu to Void Linux, building MLS kept failing because there's no genisoimage package available for Void. Seems you forgot to copy over the xorriso command from MLL to this, so I fixed that.

ivandavidov commented 6 years ago

I don't know how it is with Void, but there is no such problem on Ubuntu. Have you tried installing mkisofs instead of genisoimage on Void? Setting up your own development environment is entirely up to you. The ISO image generation process should work fine with any of these:

It is OK to introduce xorriso but please update the corresponding README section where the dependencies are described. The xorriso package has to be added and the genisoimage package has to be removed. Also, when you use xorriso in general you don't need -r, -R and -input-charset.

antoniusmisfit commented 6 years ago

I'll update the README.

antoniusmisfit commented 6 years ago

I apparently do have mkisofs installed on Void but so far I can't locate which package it came from.

ivandavidov commented 6 years ago

In that case all you need to do in your environment is to change the genisoimage invocation with mkisofs and it should work fine.

antoniusmisfit commented 6 years ago

Is the indentation all good now?

ivandavidov commented 6 years ago

In general, each pull request should follow the same structure and code/indentation style as in the original code. In this way the repository maintainer (in this case this is me) will have less overhead to deal with. This is general rule for all open source projects.

Some of the lines in your code are still not indented as in the original code. Please double check all your changes and implement the indentation according to the original style that has been used.