ivandavidov / minimal

Minimal Linux Live (MLL) is a tiny educational Linux distribution, which is designed to be built from scratch by using a collection of automated shell scripts. Minimal Linux Live offers a core environment with just the Linux kernel, GNU C library, and Busybox userland utilities.
https://ivandavidov.github.io/minimal
GNU General Public License v3.0
1.53k stars 300 forks source link

Missing CRC32 at the rootfs compression #239

Open berlin4apk opened 3 years ago

berlin4apk commented 3 years ago

https://github.com/ivandavidov/minimal/blob/4393977a3c3fe7995d3b25a8a31d0644477768a2/src/10_pack_rootfs.sh#L18

Together with the ARCH specific BJC it will maybe compress a little bit better

See also https://github.com/torvalds/linux/blob/8baef6386baaefb776bdd09b5c7630cf057c51c6/scripts/xz_wrap.sh#L23

github-actions[bot] commented 3 years ago

Thank you for contributing to Minimal Linux Live! :)

ivandavidov commented 3 years ago

Thank you, that's a really nice observation!

I'll update the initramfs generation as per your suggestions shortly.

ivandavidov commented 3 years ago

I've added the crc32 check, but the --x86 optimization seems to be breaking the QEMU test, so I'm leaving it for now.