ivandotv / pumpit

PumpIt is a small (<2KB) dependency injection container without the decorators, suitable for the browser.
MIT License
25 stars 2 forks source link

fix unbind falsy values #27

Closed intellild closed 1 year ago

intellild commented 1 year ago

Hi @ivandotv can you have a look at this

codecov[bot] commented 1 year ago

Codecov Report

Base: 99.53% // Head: 99.53% // Increases project coverage by +0.00% :tada:

Coverage data is based on head (0ade9cd) compared to base (b8c1cae). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #27 +/- ## ======================================= Coverage 99.53% 99.53% ======================================= Files 2 2 Lines 214 215 +1 Branches 73 72 -1 ======================================= + Hits 213 214 +1 Misses 1 1 ``` | [Impacted Files](https://codecov.io/gh/ivandotv/pumpit/pull/27?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ivan+Vlatkovi%C4%87) | Coverage Δ | | |---|---|---| | [src/pumpit.ts](https://codecov.io/gh/ivandotv/pumpit/pull/27/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ivan+Vlatkovi%C4%87#diff-c3JjL3B1bXBpdC50cw==) | `99.53% <100.00%> (+<0.01%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ivan+Vlatkovi%C4%87). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ivan+Vlatkovi%C4%87)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

ivandotv commented 1 year ago

Hi @intellild Thank you for trying to contribute. Your test has no assertions. And also you need to generate a changeset.

intellild commented 1 year ago

@ivandotv done

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication