search

ivanhercaz / CanaryBot

CanaryBot works in the Wikimedia projects mainly in maintenance tasks!
1 stars 0 forks source link

"Removes the duplicates automatically" enter in a loop of actions #15

Open ivanhercaz opened 5 years ago

ivanhercaz commented 5 years ago

Testing in PAWS the new functionality (#10), when the "Removes the duplicates automatically" is chosen, it enters in a loop of "Updating the log..." and "Description added to the file". Effectively, as it said, the log is updated and the description added each time it appears.

This gist shows three files. The first and the second shows the error commented but in different quantity (the second is longer). And the third file is the "duplicatedFullStopsDesc.csv", the file in which the descriptions have to be saved, and it shows how the identifier and the description is repeated several and different times each time I mark a description with the option mentioned above. This can be checked in the generated log too.

Tasks:

ivanhercaz commented 5 years ago

Closed by error.

After the PR #16 I tested it first in my local machine and it works fine, not loop of any action. But when I tried it again in PAWS I experiment the same behavior. Thus I think something might be wrong with PAWS or with how the code works in PAWS. It is very strange for me and now I don't know how to deal with this issue.

@Chicocvenancio, have you any idea about it? Should I report it in the PAWS project in Phabricator? I would like to have your opinion before to take any action.

chicocvenancio commented 5 years ago

The biggest difference I can think of for PAWS is Oauth vs botpassword that is commonly used in local development. This is probably a pywikibot bug, but I'd like to test a few things out before sending it their way.

ivanhercaz commented 5 years ago

Thank you, @chicocvenancio, for invest your time in address this issue.

The biggest difference I can think of for PAWS is Oauth vs botpassword that is commonly used in local development.

But, in theory, this should affect and even less cause this loop.

This is probably a pywikibot bug, but I'd like to test a few things out before sending it their way.

But, if it is a pywikibot bug, why in PAWS and not in the local machine? If I am not wrong and I checked it correctly, both run the same pwb version. Who knows! It seems very strange for me.

I would like to confirm: