FSP Proposal Feedback

[andywynkoop]

Wiki Page Home

• [x] Is the first page you see upon entering the wiki
• [x] Contains a welcome message
• [ ] Contains a link/placeholder for a link to the live page
• [x] All links in the right sidebar should contain each wiki page and link to the correct page
• [x] Correctly formatted
  • [x] each wiki page is listed in bullet points
  • [x] all links route the correct page

---

MVP List

• [x] Should have 7 MVPs.
  • [ ] 3 of those are User Auth, Heroku, and Production README.
  • [x] The other 4 are from the MVP List or they have clarified them with you
• [ ] Contains a description sentence of the app
  • [x] Includes the following list for the 4 app specific MVPs:
  • [x] Adequate styling
  • [x] Smooth, bug-free navigation
  • [x] Adequate and appropriate seeds to demonstrate the feature
• [x] At least one CRUD feature, which states what CRUD operations are planned (creation, reading, updating, deletion) - I think this will be
• [X] Estimates how long it will take the code each MVP*
• [x] Correctly formatted
  • [x] MVPs are listed in an ordered list
  • [x] Each MVP is broken down into bullet points

Notes

• [x] Your current time estimates will require more than 10 days! But I think search could be done in one day.
• [ ] Don't forget that production README

• [x] Is user's list the CRUD feature?

Database Schema

• [X] Contains correct datatypes

• [ ] Contains appropriate constraints/details

  • [ ] primary key
  • [ ] not null
  • [ ] unique
  • [ ] indexed
  • [ ] foreign key

• [X] Contains bullet points after the table that state which foreign keys will reference to which table, or references to the associations which will be made

• [ ] Correctly formatted

  • [ ] schema is written in a table format
  • [ ] the table's name are back_ticked
  • [ ] the table header column names are bolded
  • [ ] columns names are lowercased and snaked_cased and back_ticked

Notes

• [x] You may want to index movies on genre since you'll potentially search by category
• [x] Be careful with uniqueness constraints in list-items - you want a scoped uniqueness constraint for those two foreign keys together, not individual uniqueness in that column

---

Sample State

• [x] State shape is flat!
• [ ] State's keys are camelCased
• [ ] All keys within the values in the state are accessible in the schema
• [X] Correctly formatted
  • [X] Sample state is rendered with triple backticks, and the language ```javascript...```). This will display the state as a code block instead of a giant line of text
  • [X] Top level slices
    • [X] entities
    • [X] session
    • [X] errors (here or in ui)
    • [X] ui (if needed)
  • [X] Should NOT have nested slices, aka comments inside of posts
    • Some info from other tables is ok, for instance:
    • the author username and imageurl for a post. basically any info that the user can't change
    • like count and a boolean on whether the user likes the post instead of a likes slice

• [ ] Don't forget to include the movie/video_url - you won't store these in the db, but they'll be included in front end state

Backend Routes

• [X] Contains the following sections: HTML, API Endpoints(Backend)

• [X] Each route has a description

• [X] API Endpoint routes contains wildcard variables written in snake_case

• [X] Routes does not contain superfluous routes

• [X] Have API routes that will allow the front end to get all info it needs and does not have unneeded routes:

  • probably doesn't need a GET likes api endpoint because that info comes through the post show

• [ ] Everything should be nested under /api except /

Frontend Routes

• [ ] Frontend routes contains wildcard variables written in camelCase
• [ ] Correctly formatted
  • [ ] Routes are displayed with inline coding text (backticks)

[andywynkoop]

Great job so far! slack me if you have any questions. We'll meet sometime tomorrow

[ivank710]

Hey Andy, I think I'm finished with user auth, but I'm not so sure. Can you review it? Here is my link: https://my--flix.herokuapp.com/#/

[ivank710]

Also, what do you think I should work on this weekend? I was thinking about learning active storage, finding videos, and preparing my index page for browsing videos