search

ivankorobkov / python-inject

Python dependency injection
Apache License 2.0
672 stars 77 forks source link

Even more precise typing #47

Closed samiur closed 4 years ago

samiur commented 4 years ago

This PR adds even more precise typing to this project, attempting to distinguish between when you've put in just a simple Hashable and a Class.

This is based on the PR started by @45deg in #46. Thanks for starting that work!

It also removes duplicate mypy signatures.

ivankorobkov commented 4 years ago

Hi! Thank your for a pull request. The tests fail: https://travis-ci.org/ivankorobkov/python-inject/jobs/653128752?utm_medium=notification&utm_source=github_status

Have you removed Python 3.5 compatibility?

ivankorobkov commented 4 years ago

@samiur @45deg I have removed python3.5 from travis tests and released a new version. Thanks for your pull requests.

Get it at https://pypi.org/project/Inject/4.1.0/

samiur commented 4 years ago

@ivankorobkov sorry for the delayed response! Thank you for merging the PR: it seems some of the more precise typing isn't compatible with 3.5. I really appreciate you still taking this PR despite that!