ivankorobkov / python-inject

Python dependency injection
Apache License 2.0
694 stars 79 forks source link

pip install fails on windowsOS #48

Closed sonedaiki closed 4 years ago

sonedaiki commented 4 years ago

Hello I get the following error when I pip install on windows.

UnicodeDecodeError: 'cp932' codec can't decode byte 0x93 in position 471: illegal multibyte sequence

Perhaps modifying setup.py(line7~9) as follows will cure it?

def read_description():
    with open('README.md', 'r', encoding='utf-8') as f:
        return f.read()

or

def read_description():
    with open('README.md', 'r', encoding='utf-8_sig') as f:
        return f.read()

Thanks for your works.

ivankorobkov commented 4 years ago

Done.

https://pypi.org/project/Inject/4.1.1/