Open ivanleekk opened 12 months ago
We have answered this in our Q&A section.
Team chose [response.Rejected
]
Reason for disagreement: The primary reason I wrote this bug is because people can have the same name. Addressing that in your QnA does not solve the primary issue at hand, which is the feature flaw. If two people with the same name were to apply to be TA for a mod, then you would no longer be able to use your app as intended because you can no longer manage the 2 TA's properly. Doing a simple search in the SOC group chat for common names like "john" or "ethan" yields multiple results, and even personally for the mod I TA-ed for there was another TA with the same name as me, in such situations, by attempting to introduce flawed duplicate detection, you may have reduced confusion in one aspect, but also decreased the usability of the app as a result.
As names are not unique, there can be a case where multiple TAs have the same name. However if i were to add 2 TA with the same name but all other fields changed, the product does not allow me to do so
steps to reproduce: 1) add n/abcd p/12345 e/qwert@qwert.com tele/@qwerty 2) add n/abcd p/54321 e/abcde@abcde.com tele/@abcde
expected: both ta get added actual: