nus-se-script
commented
12 months ago Team's Response
No details provided by team.
The 'Original' Bug
[The team marked this bug as a duplicate of the following bug]
Able to add TAs with different names, yet the same for other attributes.
From the above screenshot, index 13 and 14 have the same fields, but different names. Given that their phone numbers / telegram handle / email addresses are the same, it would make sense that this should not be allowed, as TAs should not just have different names, they should by right have different phone numbers, telegram handles and email addresses as well.
[original: nus-cs2103-AY2324S1/pe-interim#4711] [original labels: severity.Low type.FeatureFlaw]
Their Response to the 'Original' Bug
[This is the team's response to the above 'original' bug]
The same issue of how we check duplicates. We have to properly define how we handle duplicates.
Items for the Tester to Verify
:question: Issue duplicate status
Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)
- [ ] I disagree
Reason for disagreement: [replace this with your explanation]
## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.FunctionalityBug`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
as a phone number is a unique identifier, a duplicate phone number should not be allowed to be added, however, if i were to add a second TA who is changed for everything except for phone, they can get added
steps to reproduce 1) add n/abcd p/54321 e/abcde@abcde.com tele/@abcde
2) add n/qwerty p/54321 e/qwerty@qwerty.com tele/@qwerty
expected: error, saying duplicate person added
actual: 2nd person gets added