Closed Teque5 closed 2 years ago
@Teque5 Thank you for using the package and your issue!
1, 4. This was a gross oversight on my part. Thank you for pointing this out!
setup.py
: it creates a __version__.py
during install.I am going to ship these fixes soon bundled with minor updates to more modern pytorch version >=1.8
.
update: Currently working on these and other updates in this branch, which has a very up-to-date name xD
update: See PR #25
cplxmodule.__version__
defined.setup.py
set theversion=version
and use this up top somewhere. This might look dirty but believe me it's the best way. We use this for gnuradio/sigmf and other projects:with open(os.path.join('cplxmodule', 'init.py')) as derp: version = re.search(r'version\s=\s\'"[\'"]', derp.read()).group(1)
Due to the way that you are using relative imports (correctly) this project is compatible with Python 3.7+ and NOT prior versions. You can add an indicator for this in the setup.This was actually a bug related to your pip package reporting the same version as the version installed from git, but they were different and had different submodules. More reason to properly version.I probably have a PR for you for a different feature, but I have to get it approved for release first.