search

ivannz / cplxmodule

Complex-valued neural networks for pytorch and Variational Dropout for real and complex layers.
MIT License
138 stars 27 forks source link

Add view and view_as to Cplx #6

Closed Rikorose closed 4 years ago

ivannz commented 4 years ago

thank you for your PR, @Rikorose ! Could you, please, add some unit tests to make sure Cplx mimics the behaviour of torch.Tensor.view (including error messages from bad shapes and the like)?

PS: thank you for pr #7. I merged it, so you'll need to rebase this branch atop the master.

Rikorose commented 4 years ago

I added a unit test. Is this sufficient or can you think of more test cases that I should add?

ivannz commented 4 years ago

Great, @Rikorose ! thank you very much, looks good to me. I will have a closer look at it on saturday.